Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276Ab2FLNTs (ORCPT ); Tue, 12 Jun 2012 09:19:48 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:45783 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696Ab2FLNTr convert rfc822-to-8bit (ORCPT ); Tue, 12 Jun 2012 09:19:47 -0400 MIME-Version: 1.0 In-Reply-To: <1339505386.30984.123.camel@x61.thuisdomein> References: <1339505386.30984.123.camel@x61.thuisdomein> From: Eric Miao Date: Tue, 12 Jun 2012 21:19:25 +0800 Message-ID: Subject: Re: [PATCH] ARM: pxa: remove eseries.h To: Paul Bolle Cc: Russell King , Haojian Zhuang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1944 Lines: 47 On Tue, Jun 12, 2012 at 8:49 PM, Paul Bolle wrote: > Commit e478fe4cd50b86e95fadc415438b63fa94060b7d ("[ARM] pxa: merge all > eseries board code into eseries.c") removed all six files that included > eseries.h. Everything that this header provides is now either local to > eseries.c or entirely unused. It was apparently just an oversight to > keep this header. This header can safely be removed. > > Signed-off-by: Paul Bolle That was long time ago. I'm basically good with the removal. Haojian, could you give a simple test maybe? > --- > Testing with "git grep" for various things in the (history of the) tree. > >  arch/arm/mach-pxa/eseries.h |   14 -------------- >  1 files changed, 0 insertions(+), 14 deletions(-) >  delete mode 100644 arch/arm/mach-pxa/eseries.h > > diff --git a/arch/arm/mach-pxa/eseries.h b/arch/arm/mach-pxa/eseries.h > deleted file mode 100644 > index b96949d..0000000 > --- a/arch/arm/mach-pxa/eseries.h > +++ /dev/null > @@ -1,14 +0,0 @@ > -void __init eseries_fixup(struct tag *tags, char **cmdline, struct meminfo *mi); > - > -extern struct pxa2xx_udc_mach_info e7xx_udc_mach_info; > -extern struct pxaficp_platform_data e7xx_ficp_platform_data; > -extern int e7xx_irda_init(void); > - > -extern int eseries_tmio_enable(struct platform_device *dev); > -extern int eseries_tmio_disable(struct platform_device *dev); > -extern int eseries_tmio_suspend(struct platform_device *dev); > -extern int eseries_tmio_resume(struct platform_device *dev); > -extern void eseries_get_tmio_gpios(void); > -extern struct resource eseries_tmio_resources[]; > -extern struct platform_device e300_tc6387xb_device; > - > -- > 1.7.7.6 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/