Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754068Ab2FLTBJ (ORCPT ); Tue, 12 Jun 2012 15:01:09 -0400 Received: from terminus.zytor.com ([198.137.202.10]:44509 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611Ab2FLTBG (ORCPT ); Tue, 12 Jun 2012 15:01:06 -0400 Message-ID: <4FD791D6.5050503@zytor.com> Date: Tue, 12 Jun 2012 12:00:38 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Kent Yoder CC: "Zhang, Xiaoyan" , "linux-kernel@vger.kernel.org" , "tpmdd-devel@lists.sourceforge.net" , "debora@linux.vnet.ibm.com" , "srajiv@linux.vnet.ibm.com" , "m.selhorst@sirrix.com" , "linux-security-module@vger.kernel.org" , "james.l.morris@oracle.com" , "linux-api@vger.kernel.org" , "Cihula, Joseph" , "Wei, Gang" Subject: Re: [PATCH 1/2] driver: add PPI support in tpm driver References: <953B7F5DA8C0F44CBD2621D8763F4F6005F79F@SHSMSX101.ccr.corp.intel.com> In-Reply-To: X-Enigmail-Version: 1.4.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 493 Lines: 16 On 06/12/2012 11:57 AM, Kent Yoder wrote: > > This code looks clean - my only suggestion would be to add an #ifdef > CONFIG_ACPI around it so it compiles out on ppc. > Better yet, any way to separate it out in a separate source file? -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/