Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441Ab2FMKmA (ORCPT ); Wed, 13 Jun 2012 06:42:00 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:59991 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885Ab2FMKl6 convert rfc822-to-8bit (ORCPT ); Wed, 13 Jun 2012 06:41:58 -0400 MIME-Version: 1.0 In-Reply-To: <20120611085404.GB11439@opensource.wolfsonmicro.com> References: <1337941231.1580.19.camel@vkoul-udesk3> <20120527221956.GB25019@opensource.wolfsonmicro.com> <20120530121449.GI9947@opensource.wolfsonmicro.com> <20120531104538.GA2666@opensource.wolfsonmicro.com> <20120601083018.GH24139@opensource.wolfsonmicro.com> <20120611085404.GB11439@opensource.wolfsonmicro.com> Date: Wed, 13 Jun 2012 19:41:57 +0900 Message-ID: Subject: Re: [alsa-devel] [PATCH v5] sound/soc/lapis: add platform driver for ML7213 From: Tomoya MORINAGA To: Mark Brown Cc: Vinod Koul , alsa-devel@alsa-project.org, lars@metafoo.de, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1457 Lines: 37 On Mon, Jun 11, 2012 at 5:54 PM, Mark Brown wrote: > There are some drivers that predate the availibility of the dmaengine > framework. In case, you develop a new ASoC framework, all previous ASoC drivers should be adopted to the framework by yourself, don't you ? Because a new developer must be confused by this. > This, and the fact that the PCH driver uses dmaengine without using any > shared code, is the topic of the discussion. ?It is entirely natural > that there are no open coded drivers using cyclic DMA via dmaengine, > they have all had that code factored out. > > Please stop this and at least look at factoring this code out. ?If it > turns out that there's some reason why it's a lot of work that's one > thing but it seems clear that you've not even looked yet. ?It's like the > previous issues where you were sending patches which would clearly not > run successfully, it's not a very positive approach. OK, I'll stop this. I wanted to finish adding these patch series to upstream because we spent much resource on this. But I'm involved in other work, so I can't start now. Until now thank you for your support. Regards. -- ROHM Co., Ltd. tomoya -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/