Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754241Ab2FMOmq (ORCPT ); Wed, 13 Jun 2012 10:42:46 -0400 Received: from na3sys009aog118.obsmtp.com ([74.125.149.244]:53417 "EHLO na3sys009aog118.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754207Ab2FMOmp convert rfc822-to-8bit (ORCPT ); Wed, 13 Jun 2012 10:42:45 -0400 MIME-Version: 1.0 In-Reply-To: References: <1339429196-32584-1-git-send-email-linus.walleij@linaro.org> <20120612230630.GK19410@gmail.com> From: "Turquette, Mike" Date: Wed, 13 Jun 2012 07:42:21 -0700 Message-ID: Subject: Re: [PATCH 2/3] clk: add ICST307 driver To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, arm@kernel.org, linux-kernel@vger.kernel.org, Russell King Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 38 On Wed, Jun 13, 2012 at 1:38 AM, Linus Walleij wrote: > On Wed, Jun 13, 2012 at 1:06 AM, Mike Turquette wrote: >> On 20120611-17:39, Linus Walleij wrote: > >>> +obj-$(CONFIG_CLK_ICST) ? ? ? ? ? ? ? += clk-icst.o >> >> Is there a better place to put this than the top-level directory? > > I can put it alone in a subdirectory if you want to... It is used only > by the ARM reference designs AFAICT, shall I put these Integrator > things into clk/versatile as we use the "versatile" name to refer to all > ARM reference designs (i.e. arch/arm/plat-versatile). > drivers/clk/versatile seems sensible. I am just trying to prevent drivers/clk/ becoming very messy. If other platforms are going to use this code then the top-level location makes sense, otherwise lets use drivers/clk/versatile. >>> +struct clk * __init icst_clk_init(struct device *dev, const struct clk_icst_desc *desc) >> >> Nitpick: icst_clk_init should be renamed icst_clk_register to more >> closely resemble other clock registration functions which allocate >> memory dynamically. > > I'll fix! > Thanks! Mike > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/