Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754929Ab2FNA3L (ORCPT ); Wed, 13 Jun 2012 20:29:11 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:63949 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691Ab2FNA3J (ORCPT ); Wed, 13 Jun 2012 20:29:09 -0400 Date: Wed, 13 Jun 2012 17:29:05 -0700 From: Greg KH To: Jiri Slaby Cc: alan@linux.intel.com, linux-kernel@vger.kernel.org, jirislaby@gmail.com Subject: Re: [PATCH 16/24] PTY: add tty_port Message-ID: <20120614002905.GA3619@kroah.com> References: <1338809738-18967-1-git-send-email-jslaby@suse.cz> <1338809738-18967-17-git-send-email-jslaby@suse.cz> <20120612225544.GA13297@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120612225544.GA13297@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1380 Lines: 33 On Tue, Jun 12, 2012 at 03:55:44PM -0700, Greg KH wrote: > On Mon, Jun 04, 2012 at 01:35:30PM +0200, Jiri Slaby wrote: > > This has *no* function in the PTY driver yet. However as the tty > > buffers will move to the tty_port structure, we will need tty_port for > > all TTYs in the system, PTY inclusive. > > > > For PTYs this is ensured by allocating 2 tty_port's in pty_install, > > i.e. where the tty->link is allocated. Both tty_port's are properly > > assigned to each end of the tty. > > > > Freeing is done at the same place where tty is freed, i.e. in > > tty->ops->cleanup. > > > > This means BTW that tty_port does not outlive TTY in PTY. This might > > be a subject to change in the future if we see some problems. > > > > Signed-off-by: Jiri Slaby > > --- > > drivers/tty/pty.c | 25 +++++++++++++++++++++---- > > 1 file changed, 21 insertions(+), 4 deletions(-) > > As the locking rework got removed from Linus's tree, this patch doesn't > apply, so I've stopped at this point in the series. Argh, this was my fault, sorry, let me try this again, I missed 14 and 15 for some reason... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/