Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256Ab2FNCVr (ORCPT ); Wed, 13 Jun 2012 22:21:47 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:35791 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755042Ab2FNCVp (ORCPT ); Wed, 13 Jun 2012 22:21:45 -0400 Date: Thu, 14 Jun 2012 11:21:32 +0900 From: Tejun Heo To: Minchan Kim Cc: Fengguang Wu , Dave Chinner , Christoph Hellwig , linux-fsdevel@vger.kernel.org, LKML , Andrew Morton , Linux Memory Management List , xfs@oss.sgi.com Subject: Re: [PATCH] mm: add gfp_mask parameter to vm_map_ram() Message-ID: <20120614022132.GA3766@dhcp-172-17-108-109.mtv.corp.google.com> References: <20120612012134.GA7706@localhost> <20120613123932.GA1445@localhost> <20120614012026.GL3019@devil.redhat.com> <20120614014902.GB7289@localhost> <4FD94779.3030108@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FD94779.3030108@kernel.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 30 Hello, guys. On Thu, Jun 14, 2012 at 11:07:53AM +0900, Minchan Kim wrote: > It shouldn't work because vmap_page_range still can allocate > GFP_KERNEL by pud_alloc in vmap_pud_range. For it, I tried [1] but > other mm guys want to add WARNING [2] so let's avoiding gfp context > passing. > > [1] https://lkml.org/lkml/2012/4/23/77 > [2] https://lkml.org/lkml/2012/5/2/340 Yeah, vmalloc area doesn't support !GFP_KERNEL allocations and as Minchan said, changing this would require updating page table allocation functions on all archs. This is the same reason why percpu allocator doesn't support !GFP_KERNEL allocations which in turn made blk-throttle implement its own private percpu pool. If xfs can't live without GFP_NOFS vmalloc allocations, either it has to implement its own pool or maybe it's time to implement !GFP_KERNEL allocs for vmalloc area. I don't know. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/