Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750798Ab2FNEEx (ORCPT ); Thu, 14 Jun 2012 00:04:53 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:44759 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750702Ab2FNEEv (ORCPT ); Thu, 14 Jun 2012 00:04:51 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4FD9624D.3020600@jp.fujitsu.com> Date: Thu, 14 Jun 2012 13:02:21 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jiang Liu CC: Mel Gorman , KOSAKI Motohiro , Andrew Morton , Minchan Kim , Hugh Dickins , Keping Chen , Tony Luck , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xishi Qiu , Jiang Liu , Yasuaki ISIMATU Subject: Re: [PATCH] memory hotplug: fix invalid memory access caused by stale kswapd pointer References: <1339645491-5656-1-git-send-email-jiang.liu@huawei.com> In-Reply-To: <1339645491-5656-1-git-send-email-jiang.liu@huawei.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 20 (2012/06/14 12:44), Jiang Liu wrote: > Function kswapd_stop() will be called to destroy the kswapd work thread > when all memory of a NUMA node has been offlined. But kswapd_stop() only > terminates the work thread without resetting NODE_DATA(nid)->kswapd to NULL. > The stale pointer will prevent kswapd_run() from creating a new work thread > when adding memory to the memory-less NUMA node again. Eventually the stale > pointer may cause invalid memory access. > > Signed-off-by: Xishi Qiu > Signed-off-by: Jiang Liu > Acked-by: KAMEZAWA Hiroyuki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/