Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755552Ab2FNKCN (ORCPT ); Thu, 14 Jun 2012 06:02:13 -0400 Received: from mga01.intel.com ([192.55.52.88]:37183 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755448Ab2FNKCL (ORCPT ); Thu, 14 Jun 2012 06:02:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="165555701" Date: Thu, 14 Jun 2012 18:02:05 +0800 From: Fengguang Wu To: Jens Axboe Cc: linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org, virtualization@lists.linux-foundation.org, LKML Subject: Re: drivers/block/cpqarray.c:938:2: error: too many arguments to function lk_rq_map_sg Message-ID: <20120614100205.GA13217@localhost> References: <4fd91c3f.KAwMcygw9fFGn9Cx%wfg@linux.intel.com> <4FD984F3.3070502@kernel.dk> <20120614090151.GA12013@localhost> <4FD9A95D.40903@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FD9A95D.40903@kernel.dk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2066 Lines: 45 On Thu, Jun 14, 2012 at 11:05:33AM +0200, Jens Axboe wrote: > On 06/14/2012 11:01 AM, Fengguang Wu wrote: > > Hi Jens, > > > > On Thu, Jun 14, 2012 at 08:30:11AM +0200, Jens Axboe wrote: > >> On 06/14/2012 01:03 AM, wfg@linux.intel.com wrote: > >>> FYI, kernel build failed on > >>> > >>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git multiqueue > >>> head: e9a6aa8a0b7b93195774a9fcf551632bf3abcd97 > >>> commit: 67db7275fa4325d46853a4bfcb79acf32e48eca8 [1/3] multiqueue: a hodge podge of things > >> > >> The multiqueue branch is a private branch, it's known broken on many > >> configs at the moment. > > > > OK. Sorry my script just blindly build tests every new/updated branches > > in the tree. It does try to reduce noise level by remembering all warned > > error messages. However if it still presents a problem to the private > > branches, I can either explicitly blacklist "multiqueue", or let the > > script automatically skip commits whose "^Signed-off-by:" is still missing. > > It's not a problem that you're building various branches, as long as you > are expecting a bit of noise :-). In fact I applaud your effort on > expanding the scope of building others branches. > > But it does raise the question of how do we best signal intermediate > branches like this, so they can be avoided until they are ready. The > blacklist doesn't seem like a great choice, since then I have to > remember to remind you when it _is_ ok to build it. > > How about some arbitrary tag? Instead of checking a Signed-off-by, I > could just add a Dont-Auto-Build or something like that. What do you > think? OK, I'll add a grep for "Dont-Auto-Build". If it's found in *any* commit of the branch, the build script will skip the whole branch. Does this make sense to you? Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/