Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756167Ab2FNOHy (ORCPT ); Thu, 14 Jun 2012 10:07:54 -0400 Received: from www.linutronix.de ([62.245.132.108]:57299 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756039Ab2FNOHx (ORCPT ); Thu, 14 Jun 2012 10:07:53 -0400 Date: Thu, 14 Jun 2012 16:07:39 +0200 (CEST) From: Thomas Gleixner To: Chen Gong cc: tony.luck@intel.com, borislav.petkov@amd.com, x86@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tmp patch to fix hotplug issue in CMCI storm In-Reply-To: <1339681786-8418-1-git-send-email-gong.chen@linux.intel.com> Message-ID: References: <1339681786-8418-1-git-send-email-gong.chen@linux.intel.com> User-Agent: Alpine 2.02 (LFD 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 21 On Thu, 14 Jun 2012, Chen Gong wrote: > this patch is based on tip tree and previous 5 patches. You really don't need all this complexity to handle that. The main thing is that you clear the storm state and adjust the storm counter when the cpu goes offline (in case the state is ACTIVE). When it comes online again then you can simply let it restart cmci. If the storm on this cpu (or node) still exists then it will notice and everything falls in place. Keep it simple, really! Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/