Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Sat, 17 Aug 2002 15:13:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Sat, 17 Aug 2002 15:13:07 -0400 Received: from to-velocet.redhat.com ([216.138.202.10]:61944 "EHLO touchme.toronto.redhat.com") by vger.kernel.org with ESMTP id ; Sat, 17 Aug 2002 15:13:06 -0400 Date: Sat, 17 Aug 2002 15:17:04 -0400 From: Benjamin LaHaise To: "Eric W. Biederman" Cc: Linus Torvalds , Linux Kernel Subject: Re: [patch] reduce stack usage of sanitize_e820_map Message-ID: <20020817151704.A3894@redhat.com> References: <20020815174825.F29874@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from ebiederm@xmission.com on Sat, Aug 17, 2002 at 11:18:11AM -0600 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 23 On Sat, Aug 17, 2002 at 11:18:11AM -0600, Eric W. Biederman wrote: > Benjamin LaHaise writes: > > > Hello, > > > > Currently, sanitize_e820_map uses 0x738 bytes of stack. The patch below > > moves the arrays into __initdata, reducing stack usage to 0x34 bytes. > > Can we keep the arrays in sanitize_e820_map and just mark then static > and __initdata? That would appear to be a cleaner solution. > Polluting the global kernel name space with these is not nice. Nope. static conflicts with __initdata. If namespace pollution is a concern, just prefix them with e820_. -ben -- "You will be reincarnated as a toad; and you will be much happier." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/