Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756595Ab2FNS7z (ORCPT ); Thu, 14 Jun 2012 14:59:55 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:48942 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754479Ab2FNS7x (ORCPT ); Thu, 14 Jun 2012 14:59:53 -0400 Message-ID: <4FDA34A5.7070704@linaro.org> Date: Thu, 14 Jun 2012 19:59:49 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mark Brown CC: linus.walleij@stericsson.com, arnd@arndb.de, Linus Walleij , linux-kernel@vger.kernel.org, grant.likely@secretlab.ca, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver References: <1339428307-3850-1-git-send-email-lee.jones@linaro.org> <1339428307-3850-10-git-send-email-lee.jones@linaro.org> <4FD6F0E8.5040606@linaro.org> <4FD83AAD.2010701@linaro.org> <4FD88761.9050703@linaro.org> <20120614183636.GB30185@sirena.org.uk> <20120614184656.GD30185@sirena.org.uk> In-Reply-To: <20120614184656.GD30185@sirena.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 27 On 14/06/12 19:46, Mark Brown wrote: > On Thu, Jun 14, 2012 at 07:36:36PM +0100, Mark Brown wrote: > >> You're not understanding Linus' point. The compatible string isn't >> useful here because properties like the maximum clock rate of the bus >> depend on the board design, not the silicon. The controller may be >> perfectly happy to run at a given rate but other devices on the bus or >> the electrical engineering of the PCB itself may restrict this further. > > Sorry, I read the next revision and see this was actually resolved OK. Yes, I just went ahead created the bindings anyway. I figured it would be neater (if no more functional) to keep all the variations in DT. Especially if we had devices which only varied by one or two settings, which would still require a complete new struct using the previous method. -- Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/