Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138Ab2FNVsl (ORCPT ); Thu, 14 Jun 2012 17:48:41 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:46280 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288Ab2FNVsj (ORCPT ); Thu, 14 Jun 2012 17:48:39 -0400 Date: Fri, 15 Jun 2012 01:48:34 +0400 From: Cyrill Gorcunov To: Kees Cook Cc: Per Forlin , linux-kernel@vger.kernel.org, serge.hallyn@canonical.com, Linus Walleij , Per Forlin , Andrew Morton , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar Subject: Re: [PATCH] reboot: disable nonboot CPUs Message-ID: <20120614214834.GB14301@moon> References: <1339709115-531-1-git-send-email-per.forlin@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 23 On Thu, Jun 14, 2012 at 02:41:48PM -0700, Kees Cook wrote: > On Thu, Jun 14, 2012 at 2:25 PM, Per Forlin wrote: > > Disable the nonboot CPUs to safely migrate tasks and interrupts > > to the boot CPU. This will prevent the nonboot CPUs to > > interfer or block the boot CPU from being able to reboot > > the system successfully. > > Reviewed-by: Kees Cook > > This seems reasonable to me, though I haven't looked too deeply at the > reboot path. Looks reasonable to me as well, but better to add some more CC, since syscore_shutdown seems to call for generic irqs to shutdown when cpu get turned off already, not sure if this have any side effect and/or I've missed something (Thomas CC'ed). Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/