Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224Ab2FOIOY (ORCPT ); Fri, 15 Jun 2012 04:14:24 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:32962 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752875Ab2FOIOU (ORCPT ); Fri, 15 Jun 2012 04:14:20 -0400 Message-ID: <4FDAEED4.20601@redhat.com> Date: Fri, 15 Jun 2012 10:14:12 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Jan Kara CC: Jens Axboe , LKML , James Bottomley , linux-scsi@vger.kernel.org Subject: Re: [PATCH] scsi: Silence unnecessary warnings about ioctl to partition References: <1335953452-10460-1-git-send-email-jack@suse.cz> In-Reply-To: <1335953452-10460-1-git-send-email-jack@suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1868 Lines: 52 Il 02/05/2012 12:10, Jan Kara ha scritto: > Sometimes, warnings about ioctls to partition happen often enough that they > form majority of the warnings in the kernel log and users complain. In some > cases warnings are about ioctls such as SG_IO so it's not good to get rid of > the warnings completely as they can ease debugging of userspace problems > when ioctl is refused. > > Since I have seen warnings from lots of commands, including some proprietary > userspace applications, I don't think disallowing the ioctls for processes > with CAP_SYS_RAWIO will happen in the near future if ever. So lets just > stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed. > > CC: Paolo Bonzini > CC: Jens Axboe > CC: James Bottomley > CC: linux-scsi@vger.kernel.org > Signed-off-by: Jan Kara > --- > block/scsi_ioctl.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c > index 260fa80..9a87daa 100644 > --- a/block/scsi_ioctl.c > +++ b/block/scsi_ioctl.c > @@ -721,11 +721,14 @@ int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd) > break; > } > > + if (capable(CAP_SYS_RAWIO)) > + return 0; > + > /* In particular, rule out all resets and host-specific ioctls. */ > printk_ratelimited(KERN_WARNING > "%s: sending ioctl %x to a partition!\n", current->comm, cmd); > > - return capable(CAP_SYS_RAWIO) ? 0 : -ENOIOCTLCMD; > + return -ENOIOCTLCMD; > } > EXPORT_SYMBOL(scsi_verify_blk_ioctl); > > Ping? Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/