Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756765Ab2FOMPz (ORCPT ); Fri, 15 Jun 2012 08:15:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45357 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755818Ab2FOMPx (ORCPT ); Fri, 15 Jun 2012 08:15:53 -0400 Date: Fri, 15 Jun 2012 14:15:51 +0200 Message-ID: From: Takashi Iwai To: Cong Wang Cc: Cong Wang , linux-kernel@vger.kernel.org, Andrew Morton , Dave Young , "H. Peter Anvin" , "Rafael J. Wysocki" , Yinghai Lu Subject: Re: [PATCH] x86: revert "x86: Fix S4 regression" In-Reply-To: References: <1339478463-31172-1-git-send-email-amwang@redhat.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 39 At Fri, 15 Jun 2012 19:11:12 +0800, Cong Wang wrote: > > On Tue, Jun 12, 2012 at 1:21 PM, Cong Wang wrote: > > > > Takashi, could you help to test if the S4 regression is still > > there after this patch? > > Hello, > > Any comments? > > I have tested this revert on my laptop, with running simple > "suspend and resume" test for several times, I didn't see any > problem. Sorry for the late response. The problem happens only on certain laptops. I've tested the recent IvyBridge laptops and these were OK with the reverted patch. But a SandyBridge laptop, the one I tested in the last year, still hits the S4 problem with the reverted kernel. But, the recent kernels seem to have other S4 problems on this machine, so it's not 100% clear whether it's triggered by that. At least, it jumpts to the boot at S4 resume more frequently when the patch is reverted. So, I need to start from 2.6.32 again to see what regressions have been introduced. It'll take time, since I'd have to S4 20 cycles for reproducing the bug. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/