Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757127Ab2FOOue (ORCPT ); Fri, 15 Jun 2012 10:50:34 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:63522 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754780Ab2FOOud convert rfc822-to-8bit (ORCPT ); Fri, 15 Jun 2012 10:50:33 -0400 MIME-Version: 1.0 Reply-To: axel.lin@gmail.com In-Reply-To: References: From: Axel Lin Date: Fri, 15 Jun 2012 22:50:12 +0800 Message-ID: Subject: Re: [PATCH v2] regulator: add new regulator driver for lp872x To: "Kim, Milo" Cc: Mark Brown , "linux-kernel@vger.kernel.org" , "Girdwood, Liam" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 18 > +static struct regulator_init_data > +*lp872x_find_regulator_init_data(int idx, struct lp872x *lp) > +{ > + ? ? ? int i; > + ? ? ? int base = lp->chipid == LP8725 ? LP8725_ID_BASE : 0; > + ? ? ? int id = idx + base; > + > + ? ? ? for (i = 0 ; i < LP872X_MAX_REGULATORS ; i++) LP872X_MAX_REGULATORS is 9. But for LP8720, the LP8720_NUM_REGULATORS is 6. So this should be: for (i = 0 ; i < lp->num_regulators ; i++) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/