Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757224Ab2FOQMf (ORCPT ); Fri, 15 Jun 2012 12:12:35 -0400 Received: from mail132.messagelabs.com ([216.82.242.115]:21708 "EHLO mail132.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755332Ab2FOQMd (ORCPT ); Fri, 15 Jun 2012 12:12:33 -0400 X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-11.tower-132.messagelabs.com!1339776752!11540637!1 X-Originating-IP: [216.166.12.32] X-StarScan-Version: 6.5.10; banners=-,-,- X-VirusChecked: Checked From: H Hartley Sweeten To: Ian Abbott , Randy Dunlap CC: Stephen Rothwell , "linux-next@vger.kernel.org" , LKML , "devel@driverdev.osuosl.org" , Greg Kroah-Hartman , Ian Abbott , Frank Mori Hess Date: Fri, 15 Jun 2012 11:12:08 -0500 Subject: RE: linux-next: Tree for Jun 14 (staging/comedi) Thread-Topic: linux-next: Tree for Jun 14 (staging/comedi) Thread-Index: Ac1K6YQcdz1+zsOZS0C5MlQVnnNP5QAJ5SvQ Message-ID: References: <20120614162901.798d7661ea87e6134eee6f3a@canb.auug.org.au> <4FDA59D7.3050200@xenotime.net> <4FDB1B8A.8060005@mev.co.uk> In-Reply-To: <4FDB1B8A.8060005@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q5FGCj1a007757 Content-Length: 2771 Lines: 66 On Friday, June 15, 2012 4:25 AM, Ian Abbott wrote: > On 2012-06-14 22:38, Randy Dunlap wrote: >> On 06/13/2012 11:29 PM, Stephen Rothwell wrote: >> >>> Hi all, >>> >>> Changes since 20120613: >> >> >> >> when CONFIG_PCMCIA is not enabled: >> >> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_labpc_cs.ko] undefined! >> ERROR: "pcmcia_unregister_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> ERROR: "pcmcia_register_driver" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> ERROR: "pcmcia_enable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> ERROR: "pcmcia_loop_config" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> ERROR: "pcmcia_request_io" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> ERROR: "pcmcia_disable_device" [drivers/staging/comedi/drivers/ni_daq_700.ko] undefined! >> >> >> Full randconfig file is attached. > > This seems to be caused by this commit in the linux-next repository: > > 4829a9967dbe3a3ab192df0bfdde281960cc1319 is the first bad commit > commit 4829a9967dbe3a3ab192df0bfdde281960cc1319 > Author: H Hartley Sweeten > Date: Tue Jun 12 17:37:10 2012 -0700 > > staging: comedi: Kconfig: cleanup depends on logic > > All of the config options for comedi depend on COMEDI being > selected. Wrap everything in an 'if COMEDI/endif' block and > remove all the individual 'depends on COMEDI' in the Kconfig. > > Also, remove the redundant && ISA/PCI/PCMCIA/USB for the if > blocks with those driver types. > > Signed-off-by: H Hartley Sweeten > Cc: Ian Abbott > Cc: Frank Mori Hess > Signed-off-by: Greg Kroah-Hartman > OK. The problem appears to be in the depends for COMEDI_PCMCIA_DRIVERS. menuconfig COMEDI_PCMCIA_DRIVERS tristate "Comedi PCMCIA drivers" depends on (PCMCIA || PCCARD) Depending on PCCARD is redundant. It must be enabled in order to select PCMCIA. Patch coming shortly. Sorry about that. Regards, Hartley ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?