Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757317Ab2FOSuI (ORCPT ); Fri, 15 Jun 2012 14:50:08 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:60035 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757187Ab2FOSuF convert rfc822-to-8bit (ORCPT ); Fri, 15 Jun 2012 14:50:05 -0400 MIME-Version: 1.0 In-Reply-To: <1339784856-1779-1-git-send-email-prakity@marvell.com> References: <1339784856-1779-1-git-send-email-prakity@marvell.com> Date: Sat, 16 Jun 2012 00:20:04 +0530 Message-ID: Subject: Re: [PATCH 1/2] regulator: core.c Pass voltage to notifier when setting voltage From: Pankaj Jangra To: Philip Rakity Cc: linux-kernel@vger.kernel.org, broonie@opensource.wolfsonmicro.com, linux-mmc@vger.kernel.org, Philip Rakity Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1288 Lines: 46 Hi, On Fri, Jun 15, 2012 at 11:57 PM, Philip Rakity wrote: > V3 > -- > > Fix type where data argument was not passed in > blocking_notifier_call_chain. > > edits to check in comments (below) > > V2 > -- > > Incorporate performance suggestions made by Mark Brown > Use linux-next as base code rather than mmc-next > > The voltage being set should be passed to the call in handler > requesting the callback. ?Currently this is not done. > > The callin handler cannot call regulator_get_voltage() to get the "The calling" > information since the mutex is held by the regulator and > deadlock occurs. > > Without this change the receiver of the call in cannot know what > action to take. ?This is used, for example, to set PAD voltages > when doing SD vccq voltage changes. > > Signed-off-by: Philip Rakity > --- Since you are submitting your patch from the different email than your Singed-off email. So you should put in first line of message From: . Regards, Pankaj Jangra -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/