Date: Sat, 16 Jun 2012 09:11:43 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@elte.hu>,
        Peter Zijlstra <peterz@infradead.org>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anton Arapov <anton@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] uprobes: write_opcode()->__replace_page() can race
 with try_to_unmap()
Message-ID: <20120616071143.GA15962@gmail.com>
References: <20120607165942.GA31966@redhat.com>
 <20120607170041.GC31974@redhat.com>
 <20120608165551.GA30683@redhat.com>
 <20120615061217.GC12051@linux.vnet.ibm.com>
 <20120615121151.GB28541@gmail.com>
 <20120615154810.GA9662@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120615154810.GA9662@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 39


* Oleg Nesterov <oleg@redhat.com> wrote:

> On 06/15, Ingo Molnar wrote:
> >
> > * Srikar Dronamraju <srikar@linux.vnet.ibm.com> wrote:
> >
> > > > @@ -228,9 +210,10 @@ static int write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> > > >  	void *vaddr_old, *vaddr_new;
> > > >  	struct vm_area_struct *vma;
> > > >  	struct uprobe *uprobe;
> > > > +	unsigned long pgoff;
> > > >  	loff_t addr;
> > > >  	int ret;
> > > > -
> > > > +retry:
> > >
> > > Just a check on coding style: Shouldnt we have a preceeding blank
> > > line before the goto label.
> >
> > Yeah, that's most likely helpful to readability.
> 
> Aaah. Srikar, sorry, I didn't notice this comment and I already
> sent 1-15. But I added the blank line in 2/15 ;)
> 
> Ingo, please let me know if I need to re-diff and resend. 
> Otherwise I'll add the blank line later, write_opcode() needs 
> more changes anyway.

No need, I've added it before I committed the patch.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/