From: "Tc, Jenny" <jenny.tc@intel.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "R, Durgadoss" <durgadoss.r@intel.com>
Subject: RE: [PATCHv2] power_supply: Register battery as a thermal zone
Thread-Topic: [PATCHv2] power_supply: Register battery as a thermal zone
Thread-Index: AQHNTQs71I137SCSiUGywBoF1Z1h2Jb/hstg
Date: Mon, 18 Jun 2012 05:10:57 +0000
Message-ID: <20ADAB092842284E95860F279283C564282328@BGSMSX101.gar.corp.intel.com>
References: <1336576007-8772-1-git-send-email-jenny.tc@intel.com>
 <20120618042927.GA25372@lizard>
In-Reply-To: <20120618042927.GA25372@lizard>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1784
Lines: 49

Hi Anton,

> -----Original Message-----
> From: Anton Vorontsov [mailto:cbouatmailru@gmail.com]
> Sent: Monday, June 18, 2012 9:59 AM
> To: Tc, Jenny
> Cc: linux-kernel@vger.kernel.org; R, Durgadoss
> Subject: Re: [PATCHv2] power_supply: Register battery as a thermal zone
> 
> On Wed, May 09, 2012 at 08:36:47PM +0530, Jenny TC wrote:
> > Battery and charger contribute to Thermals in most of the embedded
> > devices. So, it makes sense to identify them as Thermal zones in a
> > particular platform.
> >
> > This patch registers a thermal zone if the power supply is reporting a
> > temperature property. The thermal zone will be used by platform's
> > thermal management solution.
> >
> > Signed-off-by: Jenny TC <jenny.tc@intel.com>
> > ---
> 
> Once again, thanks for the patch! It's a nice feature.
> 
> [...]
> > @@ -206,6 +258,9 @@ int power_supply_register(struct device *parent,
> struct power_supply *psy)
> >  	goto success;
> >
> >  create_triggers_failed:
> > +	if (psy->tzd)
> > +		thermal_zone_device_unregister(psy->tzd);
> 
> This causes errors:
> 
>   CC      drivers/power/pda_power.o
> drivers/power/power_supply_core.c: In function ‘power_supply_register’:
> drivers/power/power_supply_core.c:261:9: error: ‘struct power_supply’ has
> no member named ‘tzd’
> drivers/power/power_supply_core.c:262:37: error: ‘struct power_supply’
> has no member named ‘tzd’
> make[2]: *** [drivers/power/power_supply_core.o] Error 1
> 
> I think we should just introduce unregister_thermal(). So, that's what I've
> applied:

Sorry I missed it. Thanks for adding it.  Hope you will merge it

-jtc
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?