Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751408Ab2FRLBN (ORCPT ); Mon, 18 Jun 2012 07:01:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42208 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147Ab2FRLBL (ORCPT ); Mon, 18 Jun 2012 07:01:11 -0400 Message-ID: <4FDF0A68.7080004@redhat.com> Date: Mon, 18 Jun 2012 14:00:56 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: "Michael S. Tsirkin" CC: Jan Kiszka , Thomas Gleixner , Alex Williamson , "kvm@vger.kernel.org" , "mtosatti@redhat.com" , "linux-kernel@vger.kernel.org" , "yongjie.ren@intel.com" Subject: Re: [PATCH] KVM: Use IRQF_ONESHOT for assigned device MSI interrupts References: <1338570192.23475.25.camel@bling.home> <4FC8F867.7080103@siemens.com> <1338573558.23475.41.camel@bling.home> <4FC90961.8030701@siemens.com> <4FCB2359.9020505@redhat.com> <4FCC9EAC.9090007@siemens.com> <20120608143927.GA4949@redhat.com> <4FD21151.9090608@siemens.com> <4FD5C205.5070901@redhat.com> <20120611102139.GA31197@redhat.com> In-Reply-To: <20120611102139.GA31197@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 33 On 06/11/2012 01:21 PM, Michael S. Tsirkin wrote: > On Mon, Jun 11, 2012 at 01:01:41PM +0300, Avi Kivity wrote: >> On 06/08/2012 05:50 PM, Jan Kiszka wrote: >> > >> >> >> >> Pls correct me if I'm wrong. >> > >> > Well, IIRC, the "don't loop over all vcpus with IRQs or preemption >> > disabled" was one argument against direct legacy interrupt injection as >> > well. That's what I kept in mind from those discussions. Maybe Avi can >> > comment on the current position. >> >> It's still my position. >> >> IMO we need something like struct gfn_to_hva_cache for interrupts. If >> it's in the cache, we fast-path it from the interrupt handler. If not, >> fall back to a workqueue and let it refill the cache. > > And you class the irqfd behaviour of injecting multicast > with interrupts disabled a bug then? Yes (a minor one). -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/