Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751982Ab2FRMEy (ORCPT ); Mon, 18 Jun 2012 08:04:54 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:41472 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629Ab2FRMEx (ORCPT ); Mon, 18 Jun 2012 08:04:53 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Mon, 18 Jun 2012 17:34:53 +0530 Message-ID: Subject: Re: Q: return of pinctrl_register and handing at drivers that use this function From: "devendra.aaru" To: Linus Walleij Cc: Stephen Warren , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 26 Hi Linus, On Mon, Jun 18, 2012 at 5:22 PM, Linus Walleij wrote: > On Mon, Jun 18, 2012 at 1:47 PM, devendra.aaru wrote: > >> since the pinctrl_register returns a pointer of structure type "struct >> pinctrl_dev" or NULL if it was failed to register the pinctrl driver, >> so IS_ERR checking is not required? > > Yes. (Unless I did something wrong.) > So checking the return value of pinctrl_register with IS_ERR is not required. There are drivers in pinctrl subsystem which uses the IS_ERR and may (not) check whether its null or not. you can expect a patchset of those fixes. :) > Yours, > Linus Walleij Thanks, Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/