Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277Ab2FRM15 (ORCPT ); Mon, 18 Jun 2012 08:27:57 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:57745 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792Ab2FRM14 convert rfc822-to-8bit (ORCPT ); Mon, 18 Jun 2012 08:27:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <1339946252-21019-1-git-send-email-otavio@ossystems.com.br> <1339946252-21019-2-git-send-email-otavio@ossystems.com.br> Date: Mon, 18 Jun 2012 17:57:55 +0530 Message-ID: Subject: Re: [PATCH 2/2] pinctrl: pinctrl-mxs: fix implicit declaration of free() From: "devendra.aaru" To: Linus Walleij Cc: Otavio Salvador , Fabio Estevam , fabio.estevam@freescale.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 783 Lines: 31 Hi, On Mon, Jun 18, 2012 at 11:34 AM, Linus Walleij wrote: > But: > >> ?free_group: >> - ? ? ? if (!purecfg) >> - ? ? ? ? ? ? ? free(group); >> + ? ? ? kfree(group); > > Why did you delete the if (!purecfg) clause? > One way we can say that as kfreeing of null doesn't affect (panic) anything and using it without purecfg may be ok. but as the code flow says that the group is allocated only when the purecfg is not true, so i think its better to follow that way. > Yours, > Linus Walleij Thanks, Devendra. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/