Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776Ab2FRM4y (ORCPT ); Mon, 18 Jun 2012 08:56:54 -0400 Received: from antcom.de ([188.40.178.216]:39442 "EHLO chuck.antcom.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751018Ab2FRM4v (ORCPT ); Mon, 18 Jun 2012 08:56:51 -0400 Message-ID: <4FDF2590.4010901@antcom.de> Date: Mon, 18 Jun 2012 14:56:48 +0200 From: Roland Stigge Organization: ANTCOM IT Research & Development User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:10.0.4) Gecko/20120510 Icedove/10.0.4 MIME-Version: 1.0 To: Alexandre Pereira da Silva CC: Linus Walleij , cjb@laptop.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, rmk+kernel@arm.linux.org.uk, ulf.hansson@stericsson.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, spi-devel-general@lists.sourceforge.net Subject: Re: [PATCH] spi: spi-pl022: Adjust probe() to of_get_named_gpio() returning -EPROBE_DEFER References: <1340011219-31657-1-git-send-email-stigge@antcom.de> In-Reply-To: X-Enigmail-Version: 1.4 OpenPGP: url=subkeys.pgp.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1524 Lines: 40 On 06/18/2012 01:51 PM, Alexandre Pereira da Silva wrote: > On Mon, Jun 18, 2012 at 8:47 AM, Linus Walleij wrote: >> On Mon, Jun 18, 2012 at 11:20 AM, Roland Stigge wrote: >> >>> The patch to gpiolib-of.c providing -EPROBE_DEFER as a hint to defer >>> of_get_named_gpio*() to a later probe() breaks spi-pl022.c. >>> >>> This patch adjusts to this change, using -EPROBE_DEFER as indication to defer. >>> >>> Signed-off-by: Roland Stigge >> >> Acked-by: Linus Walleij > > Acked-by: Alexandre Pereira da Silva > >>> Should this patch be joined with gpiolib-of's patch to of_get_named_gpio()? Or >>> should they just be issued as a series? >> >> If it's not bisectable unless you change this in the same patch then join >> them. Else I'd put them in a series and try to figure out a good tree for >> merging them. > > Ok, so lets keep the original patch as is for now. When Linus Acked both patches for *spi-pl022* (dt + gpio/defer fix), and they are not yet applied, please merge them. No need to introduce intermediate breakage. You can keep my Signed or Acked line for exactly this. We'll keep the patch for *gpiolib-of* separate, of course. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/