Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752280Ab2FRNaY (ORCPT ); Mon, 18 Jun 2012 09:30:24 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48381 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404Ab2FRNaQ (ORCPT ); Mon, 18 Jun 2012 09:30:16 -0400 Date: Mon, 18 Jun 2012 15:30:12 +0200 From: Michal Hocko To: Kamezawa Hiroyuki Cc: linux-mm , Linux Kernel Mailing List , cgroups@vger.kernel.org, Andrew Morton , Johannes Weiner Subject: Re: [PATCH 1/2] memcg: remove -EINTR at rmdir() Message-ID: <20120618133012.GB2313@tiehlicka.suse.cz> References: <4FDF17A3.9060202@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FDF17A3.9060202@jp.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2137 Lines: 64 On Mon 18-06-12 20:57:23, KAMEZAWA Hiroyuki wrote: > 2 follow-up patches for "memcg: move charges to root cgroup if use_hierarchy=0", > developped/tested onto memcg-devel tree. Maybe no HUNK with -next and -mm.... > -Kame > == > memcg: remove -EINTR at rmdir() > > By commit "memcg: move charges to root cgroup if use_hierarchy=0", > no memory reclaiming will occur at removing memory cgroup. OK, so the there are only 2 reasons why move_parent could fail in this path. 1) it races with somebody else who is uncharging or moving the charge and 2) THP split. 1) works for us and 2) doens't seem to be serious enough to expect that it would stall rmdir on the group for unbound amount of time so the change is safe (can we make this into the changelog please?). > So, we don't need to take care of user interrupt by signal. This > patch removes it. > (*) If -EINTR is returned here, cgroup will show WARNING. > > Signed-off-by: KAMEZAWA Hiroyuki Acked-by: Michal Hocko > --- > mm/memcontrol.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0623300..cf8a0f6 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -3890,9 +3890,6 @@ move_account: > ret = -EBUSY; > if (cgroup_task_count(cgrp) || !list_empty(&cgrp->children)) > goto out; > - ret = -EINTR; > - if (signal_pending(current)) > - goto out; > /* This is for making all *used* pages to be on LRU. */ > lru_add_drain_all(); > drain_all_stock_sync(memcg); > -- > 1.7.4.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/