Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752892Ab2FRP2Z (ORCPT ); Mon, 18 Jun 2012 11:28:25 -0400 Received: from mail-yw0-f46.google.com ([209.85.213.46]:46506 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab2FRP2X convert rfc822-to-8bit (ORCPT ); Mon, 18 Jun 2012 11:28:23 -0400 MIME-Version: 1.0 In-Reply-To: <4FDF4345.40508@itdev.co.uk> References: <1339992522-22073-1-git-send-email-djkurtz@chromium.org> <1339992522-22073-15-git-send-email-djkurtz@chromium.org> <4FDF4345.40508@itdev.co.uk> From: Daniel Kurtz Date: Mon, 18 Jun 2012 23:28:01 +0800 X-Google-Sender-Auth: c2xhhJKWFvY0_2l15uSK-EFul64 Message-ID: Subject: Re: [PATCH 14/22 v4] Input: atmel_mxt_ts - don't re-read matrix after applying pdata To: Nick Dyer Cc: Dmitry Torokhov , Henrik Rydberg , Joonyoung Shim , linux-input@vger.kernel.org, Iiro Valkonen , Benson Leung , Yufeng Shen , Olof Johansson , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1186 Lines: 33 On Mon, Jun 18, 2012 at 11:03 PM, Nick Dyer wrote: > > Daniel Kurtz wrote: > > The matrix x/y size in the Info ID Block represents the number of x/y > > trace lines on the device. ?There is no need to re-read them after > > applying pdata config, since pdata only configures the object table > > etnries. ?The matrix size read from the ID can only be updated by a > > firmware update. > > This isn't correct. For example, mXT224 can be configured as 16x14, 17x13, > 18x12, etc. This only takes effect when the chip is reset, which is why it > is necessary to re-read them after applying the config. Ah, so is that what T46.1 (Mode) does? I hadn't played with that yet. Ok, I'll move this patch into the next series which cleans up all of the configuration stuff. -Dan > > > cheers > > -- > Nick Dyer > Software Engineer, ITDev Ltd > Hardware and Software Development Consultancy > Website: http://www.itdev.co.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/