Date: Mon, 18 Jun 2012 18:30:30 +0200 (CEST)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
cc: linux-kernel@vger.kernel.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 1/2 v2] regulator: support multiple dummy fixed regulators
In-Reply-To: <20120618162058.GT3974@opensource.wolfsonmicro.com>
Message-ID: <Pine.LNX.4.64.1206181826210.23884@axis700.grange>
References: <Pine.LNX.4.64.1206181017360.23884@axis700.grange>
 <20120618094145.GC3974@opensource.wolfsonmicro.com>
 <Pine.LNX.4.64.1206181145520.23884@axis700.grange>
 <20120618100657.GG3974@opensource.wolfsonmicro.com>
 <Pine.LNX.4.64.1206181212180.23884@axis700.grange>
 <20120618115738.GI3974@opensource.wolfsonmicro.com>
 <Pine.LNX.4.64.1206181755370.23884@axis700.grange>
 <20120618162058.GT3974@opensource.wolfsonmicro.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2288
Lines: 50

On Mon, 18 Jun 2012, Mark Brown wrote:

> On Mon, Jun 18, 2012 at 05:57:24PM +0200, Guennadi Liakhovetski wrote:
> > Currently regulator_register_fixed() uses a constant name to register a
> > fixed dummy regulator. This is sufficient in principle, since there is no
> > reason to register multiple such regulators. The user can simply supply all
> > consumers in one array and use it to initialise such a regulator. However,
> > in some cases it can be convenient to register multiple such regulators.
> > This is also easy to achieve by appending the device ID to the name. It is
> 
> None of this seems terribly obvious to me.  Once we're getting into
> allowing the user to specify a voltage (and possibly other parameters)
> for the regulator it's hopefully going to refer to an actual thing we
> can point at on the board rather than a virtual thing we've got to
> satisfy software so giving it a useful name seems more useful (like a
> name correspoding to the relevant supply on the schematic).  

Sorry, don't understand. What do you mean by a "virtual" supply? There is 
a device, it is functional, doesn't this mean, that something is supplying 
power to it? And if power is supplied, then it also hopefully has a 
certain voltage :) Why I need to know it - to set an MMC OCR mask.

> There's also the fact that there shouldn't be any need for unique
> regulator names internally so if it really doesn't matter we should be
> able to give everything the same name happily enough.

What about entries under /proc/sys/debug/regulator/? Don't they have to be 
unique?

Thanks
Guennadi


> > also consistent with the current behaviour of the code, that fixes a name
> > itself without giving the user a possibility to provide a custom one.
> 
> This is done on the basis that it's an entirely virtual regulator which
> doesn't have any meaningful mapping into the hardware.  If it's got a
> voltage then that's no longer true.
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/