Date: Tue, 19 Jun 2012 00:27:48 +0530
From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bug.h: Fix up powerpc build regression.
Message-ID: <20120618185747.GA727@dirshya.in.ibm.com>
Reply-To: svaidy@linux.vnet.ibm.com
References: <20120618045417.GB19803@linux-sh.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <20120618045417.GB19803@linux-sh.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1314
Lines: 31

* Paul Mundt <lethal@linux-sh.org> [2012-06-18 13:54:17]:

> The asm-generic/bug.h __ASSEMBLY__ guarding is completely bogus, which
> tripped up the powerpc build when the kernel.h include was added:
> 
> 	In file included from include/asm-generic/bug.h:5:0,
> 			 from arch/powerpc/include/asm/bug.h:127,
> 			 from arch/powerpc/kernel/head_64.S:31:
> 	include/linux/kernel.h:44:0: warning: "ALIGN" redefined [enabled by default]
> 	include/linux/linkage.h:57:0: note: this is the location of the previous definition
> 	include/linux/sysinfo.h: Assembler messages:
> 	include/linux/sysinfo.h:7: Error: Unrecognized opcode: `struct'
> 	include/linux/sysinfo.h:8: Error: Unrecognized opcode: `__kernel_long_t'
> 
> Moving the __ASSEMBLY__ guard up and stashing the kernel.h include under
> it fixes this up, as well as covering the case the original fix was
> attempting to handle.
> 
> Tested-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
Tested-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>

This build fix works fine for me for powerpc (pseries).

--Vaidy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/