From: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
To: Ken Moffat <zarniwhoop@ntlworld.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: nfs3 problem with -rc{2,3}
Thread-Topic: nfs3 problem with -rc{2,3}
Thread-Index: AQHNTMS9i2iatMLpKEGb4f4ZWuxoUpcAjD8AgAAA1ACAAAlRAIAACccAgAASfoCAAESLgIAAHiuAgAACygA=
Date: Mon, 18 Jun 2012 22:03:24 +0000
Message-ID: <1340057002.20570.31.camel@lade.trondhjem.org>
References: <20120617200700.GA15348@milliways>
	 <1340026956.2451.9.camel@lade.trondhjem.org>
	 <1340027134.2451.12.camel@lade.trondhjem.org>
	 <20120618141854.GA7962@milliways>
	 <1340031234.2451.13.camel@lade.trondhjem.org>
	 <20120618160005.GA10169@milliways> <20120618200525.GA15654@milliways>
	 <20120618215323.GA17561@milliways>
In-Reply-To: <20120618215323.GA17561@milliways>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <0ADF9212B610054F976A2C6C37D0E577@tahoe.netapp.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1520
Lines: 37

On Mon, 2012-06-18 at 22:53 +0100, Ken Moffat wrote:
> On Mon, Jun 18, 2012 at 09:05:25PM +0100, Ken Moffat wrote:
> > 
> >  I suppose I'll have to enable v4 in my configs.
> > 
>  Just to confirm, -rc3 with CONFIG_NFS_V4 added to my original
> .config appears to work fine on nfs v3.
> 
>  I suppose I could apply 4f97615d19c370d1d907ef37f8bcd9c3672851ca on
> top of the conmits which failed to compile without v4, if it is worth
> investigating this ?  It certainly fixes the error in fs/nfs/read.c,
> but I also had:
> 
> fs/nfs/direct.c:86:29: error: field ‘ds_cinfo’ has incomplete type
> 
>  in 3e9e0ca3 which would still prevent me testing at least some of
> these commits.  Seems to have been fixed *somewhere* in that series,
> otherwise 4f97615d would not have compiled.  Any suggestions for
> that ?  Alternatively would it be useful if I discovered which
> commits are affected for ds_cinfo, or should I just follow the good
> Dr.Pangloss and add V4 to my config ? ;-)

Doesn't 4f97615d19 fix the fs/nfs/direct.c problem too? It should.

Anyhow, if you can apply that on top of the commits that didn't compile,
and then continue the bisection, that would be great. We definitely do
want the !defined(CONFIG_NFS_V4) case to work in 3.5-final...

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?