Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753441Ab2FSHR2 (ORCPT ); Tue, 19 Jun 2012 03:17:28 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:35274 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753215Ab2FSHR1 (ORCPT ); Tue, 19 Jun 2012 03:17:27 -0400 Date: Tue, 19 Jun 2012 10:16:32 +0300 From: Dan Carpenter To: Anton Vorontsov Cc: Greg Kroah-Hartman , Kees Cook , Colin Cross , Tony Luck , devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, Arnd Bergmann , patches@linaro.org, Marco Stornelli , Stephen Boyd , linux-kernel@vger.kernel.org, arve@android.com, Jesper Juhl , John Stultz , Shuah Khan , Rebecca Schultz Zavin , WANG Cong , Andrew Morton , kernel-team@android.com, Thomas Meyer Subject: Re: [PATCH 6/7] pstore/ram: Make ECC size configurable Message-ID: <20120619071632.GQ4400@mwanda> References: <20120619021050.GA19387@lizard> <1340072156-6225-6-git-send-email-anton.vorontsov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1340072156-6225-6-git-send-email-anton.vorontsov@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: ucsinet22.oracle.com [156.151.31.94] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 898 Lines: 24 On Mon, Jun 18, 2012 at 07:15:55PM -0700, Anton Vorontsov wrote: > @@ -478,7 +478,7 @@ static void ramoops_register_dummy(void) > dummy_data->record_size = record_size; > dummy_data->console_size = ramoops_console_size; > dummy_data->dump_oops = dump_oops; > - dummy_data->ecc = ramoops_ecc; > + dummy_data->ecc_size = ramoops_ecc == 1 ? 16 : ramoops_ecc; > I know it's in the change log, but there should probably be a comment here as well that 1 and 16 are magic backwards compatability numbers. > dummy = platform_device_register_data(NULL, "ramoops", -1, > dummy_data, sizeof(struct ramoops_platform_data)); regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/