MIME-Version: 1.0
In-Reply-To: <CAF+7xWkopYu2CkPsdPeJ5Kr0NBbYcnf2ez-hC+RCj6QuOFcstw@mail.gmail.com>
References: <1340092423-10073-1-git-send-email-yadi.brar@samsung.com>
	<1340092423-10073-2-git-send-email-yadi.brar@samsung.com>
	<CAF+7xWkopYu2CkPsdPeJ5Kr0NBbYcnf2ez-hC+RCj6QuOFcstw@mail.gmail.com>
Date: Tue, 19 Jun 2012 13:51:03 +0530
Message-ID: <CAKew6eUQXzGfgdFhKx9-DVRCsRcJCDOrTk4ihBLhkqcpRXgYWA@mail.gmail.com>
Subject: Re: [PATCH 2/2] regulator: max77686: Implement .set_ramp_delay() callback.
From: Yadwinder Singh Brar <yadi.brar01@gmail.com>
To: axel.lin@gmail.com
Cc: linux-kernel@vger.kernel.org,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        Liam Girdwood <lrg@ti.com>, Jonghwa Lee <jonghwa3.lee@samsung.com>,
        Myungjoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chiwoong Byun <woong.byun@samsung.com>,
        Yadwinder Singh Brar <yadi.brar@samsung.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1018
Lines: 24

On Tue, Jun 19, 2012 at 1:48 PM, Axel Lin <axel.lin@gmail.com> wrote:
>> ?static struct regulator_ops max77686_ops = {
>> ? ? ? ?.list_voltage ? ? ? ? ? = regulator_list_voltage_linear,
>> ? ? ? ?.map_voltage ? ? ? ? ? ?= regulator_map_voltage_linear,
>> @@ -90,6 +114,7 @@ static struct regulator_ops max77686_buck_dvs_ops = {
>> ? ? ? ?.get_voltage_sel ? ? ? ?= regulator_get_voltage_sel_regmap,
>> ? ? ? ?.set_voltage_sel ? ? ? ?= regulator_set_voltage_sel_regmap,
>> ? ? ? ?.set_voltage_time_sel ? = regulator_set_voltage_time_sel,
>> + ? ? ? .set_ramp_delay ? ? ? ? = max77686_set_ramp_delay,
>> ?};
>
> I think what you want here is to set .set_ramp_delay callback for
> max77686_buck_dvs_ops
> rather than max77686_ops.

Yes,  I will correct it.

Thanks,
Yadwinder.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/