Date: Tue, 19 Jun 2012 10:19:07 +0000 (GMT)
From: =?euc-kr?B?x9S47cHW?= <myungjoo.ham@samsung.com>
Subject: Re: [PATCH 1/2] extcon: Set platform drvdata in gpio_extcon_probe()
 and fix irq leak
To: Axel Lin <axel.lin@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mike Lockwood <lockwood@android.com>,
        "myungjoo.ham@gmail.com" <myungjoo.ham@gmail.com>
Reply-to: myungjoo.ham@samsung.com
MIME-version: 1.0
Msgkey: 20120619101425158@myungjoo.ham
Content-type: text/plain; charset=euc-kr
MIME-version: 1.0
Message-id: <22448380.601061340101146820.JavaMail.weblogic@epml24>
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1614
Lines: 47

> Add missing platform_set_drvdata() in gpio_extcon_probe(), otherwise calling
> platform_get_drvdata in gpio_extcon_remove() returns NULL.
> 
> Also add missing free_irq call in gpio_extcon_remove().
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Thanks!


Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

I'll apply this patch to the extcon-for-next.
I would appear in http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next soon after syncing servers.


Cheers!
MyungJoo

> ---
>  drivers/extcon/extcon_gpio.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/extcon/extcon_gpio.c b/drivers/extcon/extcon_gpio.c
> index fe7a07b..8a0dcc1 100644
> --- a/drivers/extcon/extcon_gpio.c
> +++ b/drivers/extcon/extcon_gpio.c
> @@ -125,6 +125,7 @@ static int __devinit gpio_extcon_probe(struct platform_device *pdev)
>  	if (ret < 0)
>  		goto err_request_irq;
>  
> +	platform_set_drvdata(pdev, extcon_data);
>  	/* Perform initial detection */
>  	gpio_extcon_work(&extcon_data->work.work);
>  
> @@ -146,6 +147,7 @@ static int __devexit gpio_extcon_remove(struct platform_device *pdev)
>  	struct gpio_extcon_data *extcon_data = platform_get_drvdata(pdev);
>  
>  	cancel_delayed_work_sync(&extcon_data->work);
> +	free_irq(extcon_data->irq, extcon_data);
>  	gpio_free(extcon_data->gpio);
>  	extcon_dev_unregister(&extcon_data->edev);
>  	devm_kfree(&pdev->dev, extcon_data);
> -- 
> 1.7.9.5
> 
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?