Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044Ab2FSL5w (ORCPT ); Tue, 19 Jun 2012 07:57:52 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:46487 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721Ab2FSL5v convert rfc822-to-8bit (ORCPT ); Tue, 19 Jun 2012 07:57:51 -0400 MIME-Version: 1.0 In-Reply-To: References: <1340092423-10073-1-git-send-email-yadi.brar@samsung.com> <1340092423-10073-2-git-send-email-yadi.brar@samsung.com> Date: Tue, 19 Jun 2012 17:27:51 +0530 Message-ID: Subject: Re: [PATCH 2/2] regulator: max77686: Implement .set_ramp_delay() callback. From: Yadwinder Singh Brar To: axel.lin@gmail.com Cc: linux-kernel@vger.kernel.org, Mark Brown , Liam Girdwood , Jonghwa Lee , Myungjoo Ham , Kyungmin Park , Chiwoong Byun , Yadwinder Singh Brar Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 26 On Tue, Jun 19, 2012 at 1:48 PM, Axel Lin wrote: >> ?static struct regulator_ops max77686_ops = { >> ? ? ? ?.list_voltage ? ? ? ? ? = regulator_list_voltage_linear, >> ? ? ? ?.map_voltage ? ? ? ? ? ?= regulator_map_voltage_linear, >> @@ -90,6 +114,7 @@ static struct regulator_ops max77686_buck_dvs_ops = { ^^^^^^^^^^^^^^^^^^^^^^^^^ >> ? ? ? ?.get_voltage_sel ? ? ? ?= regulator_get_voltage_sel_regmap, >> ? ? ? ?.set_voltage_sel ? ? ? ?= regulator_set_voltage_sel_regmap, >> ? ? ? ?.set_voltage_time_sel ? = regulator_set_voltage_time_sel, >> + ? ? ? .set_ramp_delay ? ? ? ? = max77686_set_ramp_delay, >> ?}; > > I think what you want here is to set .set_ramp_delay callback for > max77686_buck_dvs_ops > rather than max77686_ops. Now I have seen into my code after applying this patch again, yes its set for max77686_buck_dvs_ops. I also missed to catch this in patch... :) .. Anyways, thanks for review and I think, we don't need to revise this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/