Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202Ab2FSQUl (ORCPT ); Tue, 19 Jun 2012 12:20:41 -0400 Received: from mx2.netapp.com ([216.240.18.37]:15900 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003Ab2FSQUk (ORCPT ); Tue, 19 Jun 2012 12:20:40 -0400 X-IronPort-AV: E=Sophos;i="4.75,798,1330934400"; d="scan'208";a="656483948" From: "Myklebust, Trond" To: Ken Moffat CC: "linux-kernel@vger.kernel.org" Subject: Re: nfs3 problem with -rc{2,3} : blame Thread-Topic: nfs3 problem with -rc{2,3} : blame Thread-Index: AQHNTbfMQXPaY40l50mll7MzWrSjoJcCSNMA Date: Tue, 19 Jun 2012 16:20:37 +0000 Message-ID: <1340122836.3754.9.camel@lade.trondhjem.org> References: <20120617200700.GA15348@milliways> <1340026956.2451.9.camel@lade.trondhjem.org> <1340027134.2451.12.camel@lade.trondhjem.org> <20120618141854.GA7962@milliways> <1340031234.2451.13.camel@lade.trondhjem.org> <20120618160005.GA10169@milliways> <20120618200525.GA15654@milliways> <20120618215323.GA17561@milliways> <1340057002.20570.31.camel@lade.trondhjem.org> <20120618221052.GA18341@milliways> <20120619010641.GA22288@milliways> In-Reply-To: <20120619010641.GA22288@milliways> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.104.60.115] Content-Type: text/plain; charset="utf-8" Content-ID: <705F083B52752A47A603FC63C5894D0E@tahoe.netapp.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id q5JGKpmI029267 Content-Length: 2063 Lines: 51 On Tue, 2012-06-19 at 02:06 +0100, Ken Moffat wrote: > On Mon, Jun 18, 2012 at 11:10:52PM +0100, Ken Moffat wrote: > > On Mon, Jun 18, 2012 at 10:03:24PM +0000, Myklebust, Trond wrote: > > > > > > Doesn't 4f97615d19 fix the fs/nfs/direct.c problem too? It should. > > > > > > Anyhow, if you can apply that on top of the commits that didn't compile, > > > and then continue the bisection, that would be great. We definitely do > > > want the !defined(CONFIG_NFS_V4) case to work in 3.5-final... > > > > > OK (I was assuming errors in different places were from different > > causes). I'll do that after I've rerun rc3 without NFS_V4 with > > SUNRPC_DEBUG. Thanks. > > Bisection now points to: > > 6d74743b088d116e31fe1b73f47e782ee2016b94 is the first bad commit > commit 6d74743b088d116e31fe1b73f47e782ee2016b94 > Author: Trond Myklebust > Date: Mon Apr 30 13:27:31 2012 -0400 > > NFS: Simplify O_DIRECT page referencing > > The O_DIRECT code shouldn't need to hold 2 references to each > page. The > reference held by the struct nfs_page should suffice. > > Signed-off-by: Trond Myklebust > Cc: Fred Isaman > > I was going to revert that from 3.5.0-rc3 to confirm that my > problem with backups was gone, and then give it more extended > testing to prove firefox downloads were ok, but 6 of 11 hunks > failed, the code has changed and I'm not familiar with it. However you are saying that the problem is there when you compile a kernel with this commit as the head, and it goes away when you compile a kernel with commit 3e9e0ca3f19e911ce13c2e6c9858fcb41a37496c as the head? I'm confused as to how a bug in that patch could depend on CONFIG_NFS_V4, but I'll see what I can find. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@netapp.com www.netapp.com ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?