Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754512Ab2FSSlv (ORCPT ); Tue, 19 Jun 2012 14:41:51 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:63632 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955Ab2FSSlu (ORCPT ); Tue, 19 Jun 2012 14:41:50 -0400 MIME-Version: 1.0 In-Reply-To: <1340072156-6225-3-git-send-email-anton.vorontsov@linaro.org> References: <20120619021050.GA19387@lizard> <1340072156-6225-3-git-send-email-anton.vorontsov@linaro.org> Date: Tue, 19 Jun 2012 11:41:48 -0700 X-Google-Sender-Auth: aatOI4U7SCtYBV9FvENAhH0JzqA Message-ID: Subject: Re: [PATCH 3/7] pstore/ram_core: Proper checking for post_init errors (e.g. improper ECC size) From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 20 On Mon, Jun 18, 2012 at 7:15 PM, Anton Vorontsov wrote: > We will implement variable-sized ECC buffers soon, so post_init routine > might fail much more likely, so we'd better check for its errors. > > To make error handling simple, modify persistent_ram_free() to it be safe > at all times. > > Signed-off-by: Anton Vorontsov Acked-by: Kees Cook -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/