Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754580Ab2FSSoF (ORCPT ); Tue, 19 Jun 2012 14:44:05 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:38991 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787Ab2FSSoC convert rfc822-to-8bit (ORCPT ); Tue, 19 Jun 2012 14:44:02 -0400 MIME-Version: 1.0 In-Reply-To: <1340072156-6225-4-git-send-email-anton.vorontsov@linaro.org> References: <20120619021050.GA19387@lizard> <1340072156-6225-4-git-send-email-anton.vorontsov@linaro.org> Date: Tue, 19 Jun 2012 11:44:01 -0700 X-Google-Sender-Auth: kUbwCAH0kPqKXjZquNcWf9a9jf4 Message-ID: Subject: Re: [PATCH 4/7] pstore/ram_core: Better ECC size checking From: Kees Cook To: Anton Vorontsov Cc: Greg Kroah-Hartman , Colin Cross , Tony Luck , Arnd Bergmann , John Stultz , Shuah Khan , arve@android.com, Rebecca Schultz Zavin , Jesper Juhl , Randy Dunlap , Stephen Boyd , Thomas Meyer , Andrew Morton , Marco Stornelli , WANG Cong , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, patches@linaro.org, kernel-team@android.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 24 On Mon, Jun 18, 2012 at 7:15 PM, Anton Vorontsov wrote: > - Instead of exploiting unsigned overflows (which doesn't work for all > ?sizes), use straightforward checking for ECC total size not exceeding > ?initial buffer size; > > - Printing overflowed buffer_size is not informative. Instead, print > ?ecc_size and buffer_size; > > - No need for buffer_size argument in persistent_ram_init_ecc(), > ?we can address prz->buffer_size directly. > > Signed-off-by: Anton Vorontsov Acked-by: Kees Cook -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/