Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576Ab2FTCy4 (ORCPT ); Tue, 19 Jun 2012 22:54:56 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:53002 "EHLO e28smtp05.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752401Ab2FTCyz (ORCPT ); Tue, 19 Jun 2012 22:54:55 -0400 Message-ID: <4FE13B76.6020703@linux.vnet.ibm.com> Date: Wed, 20 Jun 2012 10:54:46 +0800 From: Xiao Guangrong User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Seth Jennings CC: Dan Magenheimer , Andrew Morton , LKML , linux-mm@kvack.org, Konrad Wilk , Nitin Gupta Subject: Re: [PATCH 02/10] zcache: fix refcount leak References: <4FE0392E.3090300@linux.vnet.ibm.com> <4FE03949.4080308@linux.vnet.ibm.com> <4FE08C9A.3010701@linux.vnet.ibm.com> <4FE0DBDD.2090005@linux.vnet.ibm.com> In-Reply-To: <4FE0DBDD.2090005@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit x-cbid: 12062002-8256-0000-0000-000002FB44A0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 24 On 06/20/2012 04:06 AM, Seth Jennings wrote: > On 06/19/2012 02:49 PM, Dan Magenheimer wrote: > >> My preference would be to fix it the opposite way, by >> checking and ignoring zcache_host in zcache_put_pool. >> The ref-counting is to ensure that a client isn't >> accidentally destroyed while in use (for multiple-client >> users such as ramster and kvm) and since zcache_host is a static >> struct, it should never be deleted so need not be ref-counted. > > > If we do that, we'll need to comment it. If we don't, it won't be > obvious why we are refcounting every zcache client except one. It'll > look like a bug. Okay, i will fix it like Dan's way and comment it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/