Date: Tue, 19 Jun 2012 20:31:03 -0700
From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: "'Nikolaus Voss'" <n.voss@weinmann.de>,
        "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/power/sbs-battery.c: don't trigger false
 supply_changed event
Message-ID: <20120620033103.GA18365@lizard>
References: <201205090803.q4983lYa013593@gatekeeper.vosshq.de>
 <2C89F4165782854891CDE0F3198B753C14F523E30A@HQMAIL01.nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2C89F4165782854891CDE0F3198B753C14F523E30A@HQMAIL01.nvidia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1102
Lines: 28

On Wed, May 09, 2012 at 07:51:05AM -0700, Rhyland Klein wrote:
> On Wed, 2012-05-09 at 2:31, Nikolaus Voss wrote:
> >power_supply_changed() events are triggerd based on the return value
> >of a get_property() call. However the property TECHNOLOGY is
> >hard-coded to LION in this driver, thus always succeeds.
> >
> >So, with the battery removed, this triggers a false battery present
> >uevent. This uevent triggers a new query via power_supply_uevent()
> >which again starts to query all known properties and thus leads to
> >an infinite loop of battery present/not-present uevents.
> >
> >This patch skips the battery presence detection for the hard-coded
> >property TECHNOLOGY.
> >
> >Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>
> 
> Acked-by Rhyland Klein <rklein@nvidia.com>

Applied, thanks!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/