Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504Ab2FTJLH (ORCPT ); Wed, 20 Jun 2012 05:11:07 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:34974 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751561Ab2FTJLF convert rfc822-to-8bit (ORCPT ); Wed, 20 Jun 2012 05:11:05 -0400 MIME-Version: 1.0 In-Reply-To: <20120619090110.GA1692@zhy> References: <1340094536-20873-1-git-send-email-vincent.guittot@linaro.org> <1340094536-20873-6-git-send-email-vincent.guittot@linaro.org> <20120619090110.GA1692@zhy> Date: Wed, 20 Jun 2012 11:11:04 +0200 Message-ID: Subject: Re: [PATCH v2 5/5] sched: cpu_power: enable ARCH_POWER From: Vincent Guittot To: Yong Zhang , Peter Zijlstra Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk, grant.likely@secretlab.ca, rob.herring@calxeda.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 39 On 19 June 2012 11:01, Yong Zhang wrote: > On Tue, Jun 19, 2012 at 10:28:56AM +0200, Vincent Guittot wrote: >> Heteregeneous ARM platform uses arch_scale_freq_power function >> to reflect the relative capacity of each core >> >> Signed-off-by: Vincent Guittot >> --- >> ?kernel/sched/features.h | ? ?2 +- >> ?1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/features.h b/kernel/sched/features.h >> index de00a48..d98ae90 100644 >> --- a/kernel/sched/features.h >> +++ b/kernel/sched/features.h >> @@ -42,7 +42,7 @@ SCHED_FEAT(CACHE_HOT_BUDDY, true) >> ?/* >> ? * Use arch dependent cpu power functions >> ? */ >> -SCHED_FEAT(ARCH_POWER, false) >> +SCHED_FEAT(ARCH_POWER, true) > > Hmmm...seems we can remove this knob completely. > Peter, Do you prefer to keep it or remove it completely ? Thanks > __weak arch_scale_smt_power() is doing all the trick. > > Thanks, > Yong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/