Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755586Ab2FTJT7 (ORCPT ); Wed, 20 Jun 2012 05:19:59 -0400 Received: from casper.infradead.org ([85.118.1.10]:54565 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726Ab2FTJT6 convert rfc822-to-8bit (ORCPT ); Wed, 20 Jun 2012 05:19:58 -0400 Message-ID: <1340183979.21745.78.camel@twins> Subject: Re: [PATCH v2 5/5] sched: cpu_power: enable ARCH_POWER From: Peter Zijlstra To: Vincent Guittot Cc: Yong Zhang , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, devicetree-discuss@lists.ozlabs.org, linux@arm.linux.org.uk, grant.likely@secretlab.ca, rob.herring@calxeda.com Date: Wed, 20 Jun 2012 11:19:39 +0200 In-Reply-To: References: <1340094536-20873-1-git-send-email-vincent.guittot@linaro.org> <1340094536-20873-6-git-send-email-vincent.guittot@linaro.org> <20120619090110.GA1692@zhy> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 38 On Wed, 2012-06-20 at 11:11 +0200, Vincent Guittot wrote: > On 19 June 2012 11:01, Yong Zhang wrote: > > On Tue, Jun 19, 2012 at 10:28:56AM +0200, Vincent Guittot wrote: > >> Heteregeneous ARM platform uses arch_scale_freq_power function > >> to reflect the relative capacity of each core > >> > >> Signed-off-by: Vincent Guittot > >> --- > >> kernel/sched/features.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/kernel/sched/features.h b/kernel/sched/features.h > >> index de00a48..d98ae90 100644 > >> --- a/kernel/sched/features.h > >> +++ b/kernel/sched/features.h > >> @@ -42,7 +42,7 @@ SCHED_FEAT(CACHE_HOT_BUDDY, true) > >> /* > >> * Use arch dependent cpu power functions > >> */ > >> -SCHED_FEAT(ARCH_POWER, false) > >> +SCHED_FEAT(ARCH_POWER, true) > > > > Hmmm...seems we can remove this knob completely. > > > > Peter, > > Do you prefer to keep it or remove it completely ? I prefer to keep it, the 'we can remove it' is true for all feature bits, they should never be twiddled in normal circumstances, its a debug feature. As such it makes sense to allow disabling the arch cpu-power fiddling. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/