Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095Ab2FTKWY (ORCPT ); Wed, 20 Jun 2012 06:22:24 -0400 Received: from merlin.infradead.org ([205.233.59.134]:36153 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756203Ab2FTKWL convert rfc822-to-8bit (ORCPT ); Wed, 20 Jun 2012 06:22:11 -0400 Message-ID: <1340187720.21745.97.camel@twins> Subject: Re: [PATCH 2/2] x86, microcode: Make reload interface per system From: Peter Zijlstra To: Borislav Petkov Cc: Henrique de Moraes Holschuh , "Yu, Fenghua" , X86-ML , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , LKML , Andreas Herrmann Date: Wed, 20 Jun 2012 12:22:00 +0200 In-Reply-To: <20120620101943.GE10012@aftab.osrc.amd.com> References: <1340121811-4477-1-git-send-email-bp@amd64.org> <1340121811-4477-3-git-send-email-bp@amd64.org> <3E5A0FA7E9CA944F9D5414FEC6C7122007737623@ORSMSX105.amr.corp.intel.com> <20120619232857.GH5996@aftab.osrc.amd.com> <1340182778.21745.75.camel@twins> <20120620095616.GB10012@aftab.osrc.amd.com> <1340186931.21745.90.camel@twins> <20120620101943.GE10012@aftab.osrc.amd.com> Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1302 Lines: 32 On Wed, 2012-06-20 at 12:19 +0200, Borislav Petkov wrote: > On Wed, Jun 20, 2012 at 12:08:51PM +0200, Peter Zijlstra wrote: > > On Wed, 2012-06-20 at 11:56 +0200, Borislav Petkov wrote: > > > sprintf(name, "intel-ucode/%02x-%02x-%02x", > > > c->x86, c->x86_model, c->x86_mask); > > > > > > > > > > but but but, the ucode image actually contains stuff for multiple > > things.. so I have to like rename it to match the actual cpu in the > > machine? > > > > That seems rather daft.. > > > > awk 'BEGIN { FS=":" } /family/ {fam=$2} /model[^ ]/ {mod=$2} /stepping/ > > {step=$2} END { printf "intel-ucode/%02x-%02x-%02x\n", fam, mod, > > step }' /proc/cpuinfo > > > > Will get me the right filename, but surely that's not user-friendly at > > all... > > I know, right. Whose idea was it to do it like that I don't know. > AFAICT, Intel delivers ucode as a single blob too, so why split it? The > driver picks out the right blob anyway. Right, so since we're mucking about with the whole interface anyway, can't we fix this too? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/