Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756573Ab2FTLCv (ORCPT ); Wed, 20 Jun 2012 07:02:51 -0400 Received: from mga01.intel.com ([192.55.52.88]:56680 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753531Ab2FTLCu (ORCPT ); Wed, 20 Jun 2012 07:02:50 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="167951135" Subject: Re: [PATCH v2 2/3] ASoC: dmaengine-pcm: Rename and deprecate snd_dmaengine_pcm_pointer From: Vinod Koul To: Lars-Peter Clausen Cc: Mark Brown , Liam Girdwood , Russell King , Ola Lilja , Shawn Guo , Mika Westerberg , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org In-Reply-To: <1339438302-12417-2-git-send-email-lars@metafoo.de> References: <1339438302-12417-1-git-send-email-lars@metafoo.de> <1339438302-12417-2-git-send-email-lars@metafoo.de> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jun 2012 16:25:01 +0530 Message-ID: <1340189701.1927.1650.camel@vkoul-udesk3> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 24 On Mon, 2012-06-11 at 20:11 +0200, Lars-Peter Clausen wrote: > Currently the sound dmaengine pcm helper functions implement the pcm_pointer > callback by trying to count the number of elapsed periods. This is done by > advancing the stream position in the dmaengine callback by one period. > Unfortunately there is no guarantee that the callback will be called for each > elapsed period. It may be possible that under high system load it is only called > once for multiple elapsed periods. This patch renames the current implementation > and documents its shortcomings and that it should not be used anymore in new > drivers. > > The next patch will introduce a new snd_dmaengine_pcm_pointer which will be > implemented based on querying the current stream position from the dma device. > > Signed-off-by: Lars-Peter Clausen Acked-by: Vinod Koul -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/