Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757446Ab2FTRSP (ORCPT ); Wed, 20 Jun 2012 13:18:15 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:50135 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153Ab2FTRSN convert rfc822-to-8bit (ORCPT ); Wed, 20 Jun 2012 13:18:13 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Bjorn Helgaas Date: Wed, 20 Jun 2012 11:17:52 -0600 Message-ID: Subject: Re: SNB PCI root information To: Yinghai Lu Cc: Ulrich Drepper , jbarnes@virtuousgeek.org, Linux Kernel Mailing List , lenb@kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1470 Lines: 30 On Tue, Jun 19, 2012 at 12:20 PM, Yinghai Lu wrote: > On Tue, Jun 19, 2012 at 5:36 AM, Bjorn Helgaas wrote: >> >> I'm not opposed to something like this, if people think it's useful. >> >> This patch sets the node quite early, before we even look at the _PXM >> information in pci_acpi_scan_root(). ?That means if the BIOS does >> supply a _PXM method and the user gives this argument, the >> user-supplied info is silently overwritten. ?To me it would make more >> sense to handle an option like this *after* we look for _PXM info. >> That way it could be used to compensate for both missing and incorrect >> _PXM info. > > yes, we can only let user input and hostbridge touch that array. > > but i'd like to only handle missing _PXM case. > > If the BIOS provide wrong _PXM, that BIOS really should be fixed at first. I don't understand this. Is there an *advantage* to silently throwing away the information the user specified on the command line? If the user goes to the trouble of discovering and using a command line argument, I think that user-supplied information should override anything the kernel can figure out on its own. Ulrich, do you have an opinion either way? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/