Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758274Ab2FTW3O (ORCPT ); Wed, 20 Jun 2012 18:29:14 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:59601 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754766Ab2FTW3N (ORCPT ); Wed, 20 Jun 2012 18:29:13 -0400 From: Luis Henriques To: Andrew Morton Cc: Bret Towe , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com, mfasheh@suse.com, jlbec@evilplan.org, Sunil Mushran Subject: Re: BUG in ofcs2_change_file_space References: <87bokddfr9.fsf@canonical.com> <20120620145659.a5fff5f6.akpm@linux-foundation.org> Date: Wed, 20 Jun 2012 23:29:10 +0100 In-Reply-To: <20120620145659.a5fff5f6.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 20 Jun 2012 14:56:59 -0700") Message-ID: <87pq8tk47d.fsf@canonical.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1781 Lines: 56 Andrew Morton writes: > On Wed, 20 Jun 2012 19:01:30 +0100 > Luis Henriques wrote: > >> >> a patch has been available for this for a while now >> >> found here: http://oss.oracle.com/pipermail/ocfs2-devel/2012-January/008464.html >> >> but it still has not hit mainline >> >> is there any way we can get this included? >> >> I believe something like this would be more appropriated, as a NULL as the >> 'file' parameter seems to be valid in that context: >> >> --- >> fs/ocfs2/file.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c >> index 6e39668..84822a4 100644 >> --- a/fs/ocfs2/file.c >> +++ b/fs/ocfs2/file.c >> @@ -1950,7 +1950,7 @@ static int __ocfs2_change_file_space(struct file *file, struct inode *inode, >> if (ret < 0) >> mlog_errno(ret); >> >> - if (file->f_flags & O_SYNC) >> + if (file && (file->f_flags & O_SYNC)) >> handle->h_sync = 1; >> >> ocfs2_commit_trans(osb, handle); > > Sunil, does this look OK to you? And Bret, can you please test it? > > Luis, can you please prepare a proper, signed-off, changelogged version > of this and I'll grab it, thanks. > Sure, I'll send it in a minute. Cheers, -- Luis > > > I'm not seeing any OCFS2 activity in mainline from Joel and Mark in six > months, so I'm getting those i-have-a-new-subsystem-to-maintain > feelings. > > If anyone else has any urgent OCFS2 patches then please resend them, cc > myself and cc linux-kernel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/