Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757721Ab2FTWmz (ORCPT ); Wed, 20 Jun 2012 18:42:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50126 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953Ab2FTWmy (ORCPT ); Wed, 20 Jun 2012 18:42:54 -0400 Date: Wed, 20 Jun 2012 15:42:52 -0700 From: Andrew Morton To: Luis Henriques Cc: Bret Towe , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, mfasheh@suse.com, jlbec@evilplan.org, sunil.mushran@oracle.com Subject: Re: [PATCH] ocfs2: Fix NULL pointer dereferrence in __ocfs2_change_file_space Message-Id: <20120620154252.7dc7a817.akpm@linux-foundation.org> In-Reply-To: <1340231684-1667-1-git-send-email-luis.henriques@canonical.com> References: <20120620145659.a5fff5f6.akpm@linux-foundation.org> <1340231684-1667-1-git-send-email-luis.henriques@canonical.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 38 On Wed, 20 Jun 2012 23:34:44 +0100 Luis Henriques wrote: > As ocfs2_fallocate() will invoke __ocfs2_change_file_space() with a NULL > as the first parameter (file), it may trigger a NULL pointer dereferrence > due to a missing check. See http://bugs.launchpad.net/bugs/1006012. > > Signed-off-by: Luis Henriques > --- > fs/ocfs2/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c > index 6e39668..84822a4 100644 > --- a/fs/ocfs2/file.c > +++ b/fs/ocfs2/file.c > @@ -1950,7 +1950,7 @@ static int __ocfs2_change_file_space(struct file *file, struct inode *inode, > if (ret < 0) > mlog_errno(ret); > > - if (file->f_flags & O_SYNC) > + if (file && (file->f_flags & O_SYNC)) > handle->h_sync = 1; > > ocfs2_commit_trans(osb, handle); OK, at least it can't hurt ;) I tagged it for -stable backporting. Please don't forget the cc's and Tested-by:s. There are quite a lot of people involved in that launchpad report and they may like to know what's going on, and can perhaps provide useful testing and review input. But I don't have their email addresses. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/