Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755375Ab2FUCiA (ORCPT ); Wed, 20 Jun 2012 22:38:00 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:39751 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143Ab2FUCh6 (ORCPT ); Wed, 20 Jun 2012 22:37:58 -0400 MIME-Version: 1.0 In-Reply-To: <20120620193438.GB2248@gmail.com> References: <20120620193438.GB2248@gmail.com> Date: Wed, 20 Jun 2012 19:37:57 -0700 X-Google-Sender-Auth: ASRjb2tJWJR4OPrrOdbrySQdang Message-ID: Subject: Re: SNB PCI root information From: Yinghai Lu To: Ingo Molnar Cc: Bjorn Helgaas , Ulrich Drepper , jbarnes@virtuousgeek.org, Linux Kernel Mailing List , lenb@kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 34 On Wed, Jun 20, 2012 at 12:34 PM, Ingo Molnar wrote: >> if the vendor provide _PXM, that _PXM should be right and be >> trusted. >> >> if the vendor does not provide _PXM, we can have command line >> to input it before user can get one updated BIOS from vendor. > > So how about an incorrect _PXM, or a slightly inefficient one? > Why shouldn't it be possible for the user to override it? Try to keep the code simple. > > I mean, if we create a parameter space that tweaks data then why > not make it complete and allow *all* firmware data to be > (optionally) modified, from the kernel boot line? that pxm/node for pci device should be consistent with srat table etc, so better solution is that BIOS keep them consistent. If BIOS provide _PXM for pci device, the _PXM should have more chance to be right. Anyway if you insist that it should cover that wrong case, let me check if it could be done simply. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/