Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758598Ab2FUDuH (ORCPT ); Wed, 20 Jun 2012 23:50:07 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:42804 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758523Ab2FUDuF (ORCPT ); Wed, 20 Jun 2012 23:50:05 -0400 MIME-Version: 1.0 In-Reply-To: References: <20120620193438.GB2248@gmail.com> Date: Wed, 20 Jun 2012 20:50:03 -0700 X-Google-Sender-Auth: ceDCwFNB6vnPGQcWzqEMi-uZq-g Message-ID: Subject: Re: SNB PCI root information From: Yinghai Lu To: Ingo Molnar Cc: Bjorn Helgaas , Ulrich Drepper , jbarnes@virtuousgeek.org, Linux Kernel Mailing List , lenb@kernel.org, x86@kernel.org, linux-pci@vger.kernel.org Content-Type: multipart/mixed; boundary=047d7b33d6502ab75304c2f369b5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7055 Lines: 120 --047d7b33d6502ab75304c2f369b5 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Jun 20, 2012 at 7:37 PM, Yinghai Lu wrote: > On Wed, Jun 20, 2012 at 12:34 PM, Ingo Molnar wrote: >>> if the vendor provide _PXM, that _PXM should be right and be >>> trusted. >>> >>> if the vendor does not provide _PXM, we can have command line >>> to input it before user can get one updated BIOS from vendor. >> >> So how about an incorrect _PXM, or a slightly inefficient one? >> Why shouldn't it be possible for the user to override it? > > Try to keep the code simple. > >> >> I mean, if we create a parameter space that tweaks data then why >> not make it complete and allow *all* firmware data to be >> (optionally) modified, from the kernel boot line? > > that pxm/node for pci device should be consistent with srat table etc, > so better solution is that BIOS keep them consistent. > > If BIOS provide _PXM for pci device, the _PXM should have more chance > to be right. > > Anyway if you insist that it should cover that wrong case, let me > check if it could be done simply. please check -v3, and it will add 40 lines. and -v2 is about 25 lines. Thanks Yinghai --047d7b33d6502ab75304c2f369b5 Content-Type: application/octet-stream; name="busnum_node_v3.patch" Content-Disposition: attachment; filename="busnum_node_v3.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h3paiuk40 U3ViamVjdDogW1BBVENIXSBQQ0ksIFg4NjogYnVzbnVtL25vZGUgYm9vdCBjb21tYW5kIGxpbmUg Zm9yIHBjaSBkZXYgbm9kZSBzZXR0aW5nLgoKU29tZSBpbnRlbCBuZXcgc2FuZHlicmlkZ2Ugb3Ig bmV3ZXIgdHdvIHNvY2tldHMgc3lzdGVtIGRvIHN1cHBvcnQgc3VwcG9ydCBudW1hCmZvciBwY2kg ZGV2aWNlcy4gQnV0IEJJT1MgZG9lcyBub3QgcHJvdmlkZSBfUFhNIHVuZGVyIHRob3NlIHJvb3Qg YnVzIGluIERTRFQuCgpBZGQgYm9vdCBjb21tYW5kIGxpbmUsIHNvIHVzZXIgY291bGQgaGF2ZSBj aGFuY2UgdG8gaW5wdXQgbm9kZSBpbmZvIGJlZm9yZQpCSU9TIGd1eXMgZmlndXJlIG91dCB0byBh ZGQgX1BYTS4KCkZvbGQgZml4IGZyb20gVWxyaWNoIHRvIHVzZSAiOyIgaW5zdGVhZCBvZiAiLCIu CnwgVGhlIHByb2JsZW0gaXMgdGhlIHBjaT0gcGFyYW1ldGVyCnwgaGFuZGxpbmcgdXNlcyAnLCcg dG8gc2VwYXJhdGUgcGFyYW1ldGVycyBhbmQgdGhlcmVmb3JlIHRoZSBzZWNvbmQgUENJCnwgcm9v dCBpbmZvcm1hdGlvbiwgc2VwYXJhdGVkIGJ5IGEgY29tbWEsIGlzIGludGVycHJldGVkIGFzIGEg bmV3IHBjaT0KfCBwYXJhbWV0ZXIuCgotdjM6IEFjY29yZGluZyB0byBCam9ybiBhbmQgSW5nbywg Y2hhbmdlIHRvIHVzZSAidXNlciBpbnB1dCBmaXJzdCIgcG9saWN5CiAgICAgc28gaXQgY291bGQg Y292ZXIgd3JvbmcgX1BYTSBjYXNlLgoKUmVwb3J0ZWQtYnk6IFVscmljaCBEcmVwcGVyIDxkcmVw cGVyQGdtYWlsLmNvbT4KU2lnbmVkLW9mZi1ieTogWWluZ2hhaSBMdSA8eWluZ2hhaUBrZXJuZWwu b3JnPgoKLS0tCiBEb2N1bWVudGF0aW9uL2tlcm5lbC1wYXJhbWV0ZXJzLnR4dCB8ICAgIDUgKysr KysKIGFyY2gveDg2L2luY2x1ZGUvYXNtL3BjaV94ODYuaCAgICAgIHwgICAgMyArKysKIGFyY2gv eDg2L3BjaS9hY3BpLmMgICAgICAgICAgICAgICAgIHwgICAyMiArKysrKysrKysrKysrLS0tLS0t LS0tCiBhcmNoL3g4Ni9wY2kvY29tbW9uLmMgICAgICAgICAgICAgICB8ICAgMjggKysrKysrKysr KysrKysrKysrKysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCA5 IGRlbGV0aW9ucygtKQoKSW5kZXg6IGxpbnV4LTIuNi9Eb2N1bWVudGF0aW9uL2tlcm5lbC1wYXJh bWV0ZXJzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBsaW51eC0yLjYub3JpZy9Eb2N1bWVudGF0aW9uL2tl cm5lbC1wYXJhbWV0ZXJzLnR4dAorKysgbGludXgtMi42L0RvY3VtZW50YXRpb24va2VybmVsLXBh cmFtZXRlcnMudHh0CkBAIC0yMTk1LDYgKzIxOTUsMTEgQEAgYnl0ZXMgcmVzcGVjdGl2ZWx5LiBT dWNoIGxldHRlciBzdWZmaXhlcwogCQkJCW9ubHkgbG9vayBmb3Igb25lIGRldmljZSBiZWxvdyBh IFBDSWUgZG93bnN0cmVhbQogCQkJCXBvcnQuCiAKKwlidXNudW1fbm9kZT0gICAgW1g4Nl0gU2V0 IG5vZGUgZm9yIHJvb3QgYnVzLgorCQkJRm9ybWF0OgorCQkJPGJ1cz46PG5vZGU+WzsgLi4uXQor CQkJU3BlY2lmaWVzIG5vZGUgZm9yIGJ1cywgd2lsbCBvdmVycmlkZSBiaW9zIF9QWE0KKwkJCW9y IHByb2JlZCB2YWx1ZSBmcm9tIGhvc3RicmlkZ2UuCiAJcGNpZV9hc3BtPQlbUENJRV0gRm9yY2li bHkgZW5hYmxlIG9yIGRpc2FibGUgUENJZSBBY3RpdmUgU3RhdGUgUG93ZXIKIAkJCU1hbmFnZW1l bnQuCiAJCW9mZglEaXNhYmxlIEFTUE0uCkluZGV4OiBsaW51eC0yLjYvYXJjaC94ODYvcGNpL2Nv bW1vbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGxpbnV4LTIuNi5vcmlnL2FyY2gveDg2L3BjaS9jb21tb24u YworKysgbGludXgtMi42L2FyY2gveDg2L3BjaS9jb21tb24uYwpAQCAtNDk0LDYgKzQ5NCwzNCBA QCBpbnQgX19pbml0IHBjaWJpb3NfaW5pdCh2b2lkKQogCXJldHVybiAwOwogfQogCitpbnQgZ2V0 X3VzZXJfYnVzbnVtX25vZGUoaW50IGJ1c251bSkKK3sKKwlpbnQgYnVzLCBub2RlLCBjb3VudDsK KwljaGFyICpwOworCisJcCA9IHN0cnN0cihib290X2NvbW1hbmRfbGluZSwgImJ1c251bV9ub2Rl PSIpOworCWlmICghcCkKKwkJcmV0dXJuIC0xOworCisJcCArPSAxMjsgLyogc3RybGVuKCJidXNu dW1fbm9kZT0iKSAqLworCXdoaWxlICgqcCkgeworCQljb3VudCA9IDA7CisJCWlmIChzc2NhbmYo cCwgIiV4OiV4JW4iLCAmYnVzLCAmbm9kZSwgJmNvdW50KSAhPSAyKSB7CisJCQlwcmludGsoS0VS Tl9FUlIgIlBDSTogQ2FuJ3QgcGFyc2UgYnVzbnVtX25vZGUgaW5wdXQ6ICVzXG4iLAorCQkJCQlw KTsKKwkJCWJyZWFrOworCQl9CisJCWlmIChidXMgPT0gYnVzbnVtKQorCQkJcmV0dXJuIG5vZGU7 CisJCXAgKz0gY291bnQ7CisJCWlmICgqcCAhPSAnOycpCisJCQlicmVhazsKKwkJcCsrOworCX0K KworCXJldHVybiAtMTsKK30KKwogY2hhciAqIF9fZGV2aW5pdCAgcGNpYmlvc19zZXR1cChjaGFy ICpzdHIpCiB7CiAJaWYgKCFzdHJjbXAoc3RyLCAib2ZmIikpIHsKSW5kZXg6IGxpbnV4LTIuNi9h cmNoL3g4Ni9pbmNsdWRlL2FzbS9wY2lfeDg2LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtMi42Lm9y aWcvYXJjaC94ODYvaW5jbHVkZS9hc20vcGNpX3g4Ni5oCisrKyBsaW51eC0yLjYvYXJjaC94ODYv aW5jbHVkZS9hc20vcGNpX3g4Ni5oCkBAIC00Niw2ICs0Niw5IEBAIGVudW0gcGNpX2JmX3NvcnRf c3RhdGUgewogCXBjaV9kbWlfYmYsCiB9OwogCisvKiBwY2ktY29tbW9uLmMgKi8KK2ludCBnZXRf dXNlcl9idXNudW1fbm9kZShpbnQgYnVzbnVtKTsKKwogLyogcGNpLWkzODYuYyAqLwogCiB2b2lk IHBjaWJpb3NfcmVzb3VyY2Vfc3VydmV5KHZvaWQpOwpJbmRleDogbGludXgtMi42L2FyY2gveDg2 L3BjaS9hY3BpLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gbGludXgtMi42Lm9yaWcvYXJjaC94ODYvcGNpL2Fj cGkuYworKysgbGludXgtMi42L2FyY2gveDg2L3BjaS9hY3BpLmMKQEAgLTQzMyw3ICs0MzMsNyBA QCBzdHJ1Y3QgcGNpX2J1cyAqIF9fZGV2aW5pdCBwY2lfYWNwaV9zY2FuCiAJc3RydWN0IHBjaV9z eXNkYXRhICpzZDsKIAlpbnQgbm9kZTsKICNpZmRlZiBDT05GSUdfQUNQSV9OVU1BCi0JaW50IHB4 bTsKKwlpbnQgcHhtID0gLTE7CiAjZW5kaWYKIAogCWlmIChkb21haW4gJiYgIXBjaV9kb21haW5z X3N1cHBvcnRlZCkgewpAQCAtNDQzLDE2ICs0NDMsMjAgQEAgc3RydWN0IHBjaV9idXMgKiBfX2Rl dmluaXQgcGNpX2FjcGlfc2NhbgogCQlyZXR1cm4gTlVMTDsKIAl9CiAKLQlub2RlID0gLTE7CisJ bm9kZSA9IGdldF91c2VyX2J1c251bV9ub2RlKGJ1c251bSk7CisJaWYgKG5vZGUgPT0gLTEpIHsK ICNpZmRlZiBDT05GSUdfQUNQSV9OVU1BCi0JcHhtID0gYWNwaV9nZXRfcHhtKGRldmljZS0+aGFu ZGxlKTsKLQlpZiAocHhtID49IDApCi0JCW5vZGUgPSBweG1fdG9fbm9kZShweG0pOwotCWlmIChu b2RlICE9IC0xKQotCQlzZXRfbXBfYnVzX3RvX25vZGUoYnVzbnVtLCBub2RlKTsKLQllbHNlCi0j ZW5kaWYKKwkJcHhtID0gYWNwaV9nZXRfcHhtKGRldmljZS0+aGFuZGxlKTsKKwkJaWYgKHB4bSA+ PSAwKQorCQkJbm9kZSA9IHB4bV90b19ub2RlKHB4bSk7CisJCWlmIChub2RlICE9IC0xKQorCQkJ c2V0X21wX2J1c190b19ub2RlKGJ1c251bSwgbm9kZSk7CisJCWVsc2UKKwkJCW5vZGUgPSBnZXRf bXBfYnVzX3RvX25vZGUoYnVzbnVtKTsKKyNlbHNlCiAJCW5vZGUgPSBnZXRfbXBfYnVzX3RvX25v ZGUoYnVzbnVtKTsKKyNlbmRpZgorCX0KIAogCWlmIChub2RlICE9IC0xICYmICFub2RlX29ubGlu ZShub2RlKSkKIAkJbm9kZSA9IC0xOwo= --047d7b33d6502ab75304c2f369b5-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/