Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755030Ab2FUFZe (ORCPT ); Thu, 21 Jun 2012 01:25:34 -0400 Received: from e1.ny.us.ibm.com ([32.97.182.141]:41689 "EHLO e1.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754704Ab2FUFZd (ORCPT ); Thu, 21 Jun 2012 01:25:33 -0400 Message-ID: <4FE2B013.7090108@linux.vnet.ibm.com> Date: Thu, 21 Jun 2012 10:54:35 +0530 From: Prashanth Nageshappa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Srivatsa Vaddagiri CC: Peter Zijlstra , mingo@kernel.org, LKML , roland@kernel.org, efault@gmx.de, Ingo Molnar Subject: Re: [PATCH v3] sched: balance_cpu to consider other cpus in its group as target of (pinned) task References: <4FE06CDB.2060605@linux.vnet.ibm.com> <1340213901.21745.122.camel@twins> <20120621034059.GA9748@linux.vnet.ibm.com> <20120621042347.GA5059@linux.vnet.ibm.com> In-Reply-To: <20120621042347.GA5059@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12062105-6078-0000-0000-00000C56D225 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 25 On 06/21/2012 09:53 AM, Srivatsa Vaddagiri wrote: > * Srivatsa Vaddagiri [2012-06-21 09:10:59]: > >> Hmm ..I can see loop_break being incremented here: >> >> /* take a breather every nr_migrate tasks */ >> if (env->loop > env->loop_break) { >> env->loop_break += sched_nr_migrate_break; > > One possibility is to reset env->loop here, rather than loop_break, in > which case loop_break can remain constant across "redos" and > "more_balances" We cannot do this as env->loop is compared with env->loop_max. So, I believe resetting env->loop_break along with env->loop before "redos" and "more_balances" is the right thing to do. - Prashanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/