Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756907Ab2FUGMk (ORCPT ); Thu, 21 Jun 2012 02:12:40 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:51946 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930Ab2FUGMi (ORCPT ); Thu, 21 Jun 2012 02:12:38 -0400 Date: Wed, 20 Jun 2012 23:12:29 -0700 From: Joel Becker To: Mark Fasheh Cc: Luis Henriques , Andrew Morton , Bret Towe , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, sunil.mushran@oracle.com Subject: Re: [PATCH] ocfs2: Fix NULL pointer dereferrence in __ocfs2_change_file_space Message-ID: <20120621061228.GG21923@dhcp-172-17-9-228.mtv.corp.google.com> Mail-Followup-To: Mark Fasheh , Luis Henriques , Andrew Morton , Bret Towe , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com, sunil.mushran@oracle.com References: <20120620145659.a5fff5f6.akpm@linux-foundation.org> <1340231684-1667-1-git-send-email-luis.henriques@canonical.com> <20120620231823.GE17950@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120620231823.GE17950@wotan.suse.de> X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 34 On Wed, Jun 20, 2012 at 04:18:23PM -0700, Mark Fasheh wrote: > This should've been upstream a while ago :/ Indeed. I've been fighting my kernel.org setup and life since December. Sorry I dropped the ball on this one. Joel > > On Wed, Jun 20, 2012 at 11:34:44PM +0100, Luis Henriques wrote: > > As ocfs2_fallocate() will invoke __ocfs2_change_file_space() with a NULL > > as the first parameter (file), it may trigger a NULL pointer dereferrence > > due to a missing check. See http://bugs.launchpad.net/bugs/1006012. > > > > Signed-off-by: Luis Henriques > > Signed-off-by: Mark Fasheh > --Mark > > -- > Mark Fasheh -- There are morethings in heaven and earth, Horatio, Than are dreamt of in your philosophy. http://www.jlbec.org/ jlbec@evilplan.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/