Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217Ab2FUJHU (ORCPT ); Thu, 21 Jun 2012 05:07:20 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:43112 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759090Ab2FUJHP convert rfc822-to-8bit (ORCPT ); Thu, 21 Jun 2012 05:07:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1339203038-13069-1-git-send-email-akinobu.mita@gmail.com> Date: Thu, 21 Jun 2012 18:07:14 +0900 Message-ID: Subject: Re: [PATCH v3 1/9] string: introduce memweight From: Akinobu Mita To: Tony Luck Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Anders Larsen , Alasdair Kergon , dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, Laurent Pinchart , linux-media@vger.kernel.org, Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com, Jan Kara , linux-ext4@vger.kernel.org, Andreas Dilger , "Theodore Ts'o" , Matthew Wilcox Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 27 2012/6/21 Tony Luck : > On Fri, Jun 8, 2012 at 5:50 PM, Akinobu Mita wrote: >> ?lib/string.c ? ? ? ? ? | ? 36 ++++++++++++++++++++++++++++++++++++ > > Is lib/string.c the right place for this? ?I get a build error on the > ia64 sim_defconfig: > > ?LD ? ? ?arch/ia64/hp/sim/boot/bootloader > > It fails because it pulls in lib/lib.a(string.o) to get some > innocuous function like strcpy() ... but it also gets > given memweight() which relies on __bitmap_weight() > which it doesn't have, because it doesn't include lib/built-in.o > (which is where bitmap.o, the definer of __bitmap_weight(), has > been linked). > > Moving memweight() to lib/bitmap.c fixes the problem. But it > isn't really clear that it belongs there either. ?Perhaps it should > be its own file lib/memweight.c that gets included in lib/lib.a? I'll fix it by making lib/memweight.c as you suggested. Thanks for your report and suggestion. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/