Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758680Ab2FUOcd (ORCPT ); Thu, 21 Jun 2012 10:32:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34971 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143Ab2FUOcc (ORCPT ); Thu, 21 Jun 2012 10:32:32 -0400 Message-ID: <4FE33002.6040703@redhat.com> Date: Thu, 21 Jun 2012 10:30:26 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Peter Zijlstra CC: linux-mm@kvack.org, akpm@linux-foundation.org, aarcange@redhat.com, minchan@gmail.com, kosaki.motohiro@gmail.com, andi@firstfloor.org, hannes@cmpxchg.org, mel@csn.ul.ie, linux-kernel@vger.kernel.org, Rik van Riel Subject: Re: [PATCH -mm 4/7] mm: make page colouring code generic References: <1340057126-31143-1-git-send-email-riel@redhat.com> <1340057126-31143-5-git-send-email-riel@redhat.com> <1340277624.21745.173.camel@twins> In-Reply-To: <1340277624.21745.173.camel@twins> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 590 Lines: 15 On 06/21/2012 07:20 AM, Peter Zijlstra wrote: > On Mon, 2012-06-18 at 18:05 -0400, Rik van Riel wrote: >> Fix the x86-64 page colouring code to take pgoff into account. > > Shouldn't that be a separate patch? My idea was that it would be easier to review these two nearly identical functions together. Andrew, do you have any strong opinions? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/